Add NBGV_GitEngine=Disabled option #586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m0sa
commented
Apr 12, 2021
|
I can't tell easily from the code, since I'm unfamiliar with the architecture. Will this also address usages of |
AArnott
reviewed
Apr 17, 2021
There was a problem hiding this comment.
This looks good. Not what I think I would have done but I really like where you took it. Let's run with it. I did a couple touch-ups and modified the test file slightly. I think we need to promote more tests to run in the no-git scenario than the two I did so far. Can you find the other tests that would pass or should pass, and add a couple new ones specifically for the no-git scenario?
|
I've resolved conflicts locally and will push once I validate the result. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
Disabledas an option to theNBGV_GitEnginesetting, which turns off all git operations, but still emits expected / dummy AssemblyInfo properties.Closes #568