Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New tooling #171

Merged
merged 5 commits into from
Feb 14, 2017
Merged

New tooling #171

merged 5 commits into from
Feb 14, 2017

Conversation

galvesribeiro
Copy link
Member

  • Updated the tooling so people using VS2017 and latest released dotnet CLI can build the project again.
  • Updated build scripts to match new tooling.
  • Removed .nuspec files. They aren't necessary anymore with the new tooling.

@msftclas
Copy link

Hi @galvesribeiro, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!

The agreement was validated by Microsoft and real humans are currently evaluating your PR.

TTYL, MSBOT;

@galvesribeiro
Copy link
Member Author

@jterry75 Hey, I've updated to the new tooling here but for whatever reason AppVeyor is not able to clone the code from GH. Can you give a hand here? I'm trying to move forward with the rest of the issues to I can use it.

@jterry75
Copy link
Contributor

I dont quite understand that failure from AppVeyor. Can you rebase and push an update to get AV to try again. Seems like a node failure. We dont control that part of the clone process.

@galvesribeiro
Copy link
Member Author

@jterry75 same issue... I'll open another PR from another branch and see if it happen there...

@galvesribeiro
Copy link
Member Author

Ok, it doesn't work @jterry75. Can you open a ticket on AV?

Thank you.

@jterry75
Copy link
Contributor

Oh I didnt look closely enough. This is a bug in your AppVeyor.yml You cant copy to $PWD because that is the folder where the git checkout takes place (hence it is no longer empty). You need to copy to c: like we used to for staging or somewhere else.

@galvesribeiro
Copy link
Member Author

@jterry75 ok, fixed :)

Once we have it merged I'll look at the AutoRest thing. Thanks!

@jterry75
Copy link
Contributor

Ok one more change. Can we keep passing the version number so the AppVeyor build increments like it used to. We can hard code the major.minor in the file and use .* to have appVeyor replace it

appveyor.yml Outdated
- ps: dotnet build -c Release
- ps: dotnet pack -c Release -o $pwd /p:version=$(appveyor_build_version)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$($env:appveyor_build_version)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh! right

@jterry75 jterry75 merged commit 4d990ee into dotnet:master Feb 14, 2017
@galvesribeiro galvesribeiro deleted the new-tooling branch February 14, 2017 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants