-
Notifications
You must be signed in to change notification settings - Fork 381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New tooling #171
New tooling #171
Conversation
galvesribeiro
commented
Feb 12, 2017
- Updated the tooling so people using VS2017 and latest released dotnet CLI can build the project again.
- Updated build scripts to match new tooling.
- Removed .nuspec files. They aren't necessary anymore with the new tooling.
Hi @galvesribeiro, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution! The agreement was validated by Microsoft and real humans are currently evaluating your PR. TTYL, MSBOT; |
@jterry75 Hey, I've updated to the new tooling here but for whatever reason AppVeyor is not able to clone the code from GH. Can you give a hand here? I'm trying to move forward with the rest of the issues to I can use it. |
I dont quite understand that failure from AppVeyor. Can you rebase and push an update to get AV to try again. Seems like a node failure. We dont control that part of the clone process. |
@jterry75 same issue... I'll open another PR from another branch and see if it happen there... |
Ok, it doesn't work @jterry75. Can you open a ticket on AV? Thank you. |
Oh I didnt look closely enough. This is a bug in your AppVeyor.yml You cant copy to $PWD because that is the folder where the git checkout takes place (hence it is no longer empty). You need to copy to c: like we used to for staging or somewhere else. |
@jterry75 ok, fixed :) Once we have it merged I'll look at the AutoRest thing. Thanks! |
Ok one more change. Can we keep passing the version number so the AppVeyor build increments like it used to. We can hard code the |
appveyor.yml
Outdated
- ps: dotnet build -c Release | ||
- ps: dotnet pack -c Release -o $pwd /p:version=$(appveyor_build_version) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
$($env:appveyor_build_version)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh! right