Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CSPROJ files for latest VS 2017 #169

Closed
jasoncouture opened this issue Feb 10, 2017 · 2 comments
Closed

Update CSPROJ files for latest VS 2017 #169

jasoncouture opened this issue Feb 10, 2017 · 2 comments

Comments

@jasoncouture
Copy link
Contributor

Project does not build correctly in latest version VS 2017, this is due to the addition of default compile items, as outlined here: https://github.com/dotnet/core/blob/master/release-notes/1.0/sdk/1.0-rc3-default-compile-items.md

Need to add

<PropertyGroup>
    <EnableDefaultCompileItems>false</EnableDefaultCompileItems>
</PropertyGroup>

to each .csproj file, this should not break existing versions and should allow the new versions to work correctly.

I have already made this change while doing #166 and #168, I will be submitting a pull request for all 3 issues shortly.
jasoncouture added a commit to jasoncouture/Docker.DotNet that referenced this issue Feb 10, 2017
@jasoncouture
CancellationToken support (dotnet#166)
b68cd57 
Timeout configuration support (dotnet#168)
Fixed project files for VS2017 RC as noted here: https://aka.ms/sdkimplicititems (dotnet#169)
@jasoncouture jasoncouture mentioned this issue Feb 10, 2017
Merged
@galvesribeiro
Copy link
Member

I've updated the projects and removed the nuget packages on #171. It has the proper update for the new format and not just EnableDefaultCompileItems

@jasoncouture
Copy link
Contributor Author

Excellent, I will remove from my PR and close this.

jterry75 pushed a commit that referenced this issue Feb 22, 2017
@jasoncouture @jterry75
Multiple issues fixed, see details (#170)
9d156d1 
* CancellationToken support (#166)
Timeout configuration support (#168)
Fixed project files for VS2017 RC as noted here: https://aka.ms/sdkimplicititems (#169)

* Make DefaultTimeout an auto-property

* Fixed project files broken by merge.
It appears the merge removed the includes, but did not remove the added Ignore property, thus no files (or few files depending on the project) were loaded causing compilation to fail.

* Constructor change as requested by @jterry75
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jasoncouture @galvesribeiro