Add Job info to DisassemblyDiagnoser report headers #2884
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…th arguments Fixes dotnet#2724 When running BenchmarkRunner.Run<T>() or BenchmarkRunner.Run(Type) with arguments on an invalid benchmark type (no [Benchmark] methods), the runner threw an unhandled InvalidOperationException instead of returning a validation error. Changes: - Replace .Single() with .SingleOrDefault() in RunWithDirtyAssemblyResolveHelper - Return Summary.ValidationFailed when no benchmarks are found - Enable and update tests for args scenarios in RunningEmptyBenchmarkTests.cs"
When using multiple coreruns, the disassembly report headers were identical, making it impossible to distinguish which assembly belongs to which corerun.
Changes:
- Add Job DisplayInfo to markdown header: ## {RuntimeInfo} (Job: {JobDisplayInfo})
- Add Job info as <h3> in HTML exporter
- Add Job info to diff exporter comparison output
- Add tests verifying Job info is included in headers"
timcassell
approved these changes
Nov 29, 2025
Collaborator
timcassell
left a comment
timcassell
left a comment
There was a problem hiding this comment.
Thanks @Shrinidhi203
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2573
Problem
When using multiple coreruns (e.g.,
--coreRun /base/corerun /diff/corerun), the disassembly report (*-asm.md)showed identical headers, making it hard to distinguish which assembly belongs to which corerun:
.NET 9.0.0 (42.42.42.42424), X64 RyuJIT AVX-512F+CD+BW+DQ+VL+VBMI
some asm
.NET 9.0.0 (42.42.42.42424), X64 RyuJIT AVX-512F+CD+BW+DQ+VL+VBMI
some asm
Solution
Add Job DisplayInfo to the headers so users can distinguish between multiple coreruns:
.NET 9.0.0 (42.42.42.42424), X64 RyuJIT AVX-512F+CD+BW+DQ+VL+VBMI (Job: Toolchain=/base/corerun)
some asm
.NET 9.0.0 (42.42.42.42424), X64 RyuJIT AVX-512F+CD+BW+DQ+VL+VBMI (Job: Toolchain=/diff/corerun)
some asm
Changes
GithubMarkdownDisassemblyExporter.cs- Add Job info inline in headerHtmlDisassemblyExporter.cs- Add Job info as<h3>tagGithubMarkdownDiffDisassemblyExporter.cs- Add Job info to comparison output