Commit be0ea1e
authored
Add Job info to DisassemblyDiagnoser report headers (#2884)
* "Fix unhandled exception when running invalid type-based benchmark with arguments
Fixes #2724
When running BenchmarkRunner.Run<T>() or BenchmarkRunner.Run(Type) with
arguments on an invalid benchmark type (no [Benchmark] methods), the runner
threw an unhandled InvalidOperationException instead of returning a validation error.
Changes:
- Replace .Single() with .SingleOrDefault() in RunWithDirtyAssemblyResolveHelper
- Return Summary.ValidationFailed when no benchmarks are found
- Enable and update tests for args scenarios in RunningEmptyBenchmarkTests.cs"
* Fix StyleCop SA1028: Remove trailing whitespace
* "Add assertion for failure in test per maintainer feedback"
* "Add Job info to DisassemblyDiagnoser report headers Fixes #2573
When using multiple coreruns, the disassembly report headers were identical, making it impossible to distinguish which assembly belongs to which corerun.
Changes:
- Add Job DisplayInfo to markdown header: ## {RuntimeInfo} (Job: {JobDisplayInfo})
- Add Job info as <h3> in HTML exporter
- Add Job info to diff exporter comparison output
- Add tests verifying Job info is included in headers"1 parent dde78c5 commit be0ea1e
File tree
4 files changed
+70
-2
lines changed- src/BenchmarkDotNet/Disassemblers/Exporters
- tests/BenchmarkDotNet.Tests/Disassemblers
4 files changed
+70
-2
lines changedLines changed: 2 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
90 | 90 | | |
91 | 91 | | |
92 | 92 | | |
93 | | - | |
| 93 | + | |
| 94 | + | |
94 | 95 | | |
95 | 96 | | |
96 | 97 | | |
| |||
Lines changed: 2 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
26 | 26 | | |
27 | 27 | | |
28 | 28 | | |
29 | | - | |
| 29 | + | |
| 30 | + | |
30 | 31 | | |
31 | 32 | | |
32 | 33 | | |
| |||
Lines changed: 1 addition & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
52 | 52 | | |
53 | 53 | | |
54 | 54 | | |
| 55 | + | |
55 | 56 | | |
56 | 57 | | |
57 | 58 | | |
| |||
Lines changed: 65 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
0 commit comments