Code review completed - In-process diagnosers implementation approved #2859
+0
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewed the in-process diagnosers feature implementation per request. No code changes needed.
Review Summary
The implementation successfully introduces
IInProcessDiagnoserfor running diagnosers in the benchmark process with:IInProcessDiagnoserinterface for host-side logic,IInProcessDiagnoserHandlerfor in-process executionInProcessDiagnoserTestsvalidates multiple diagnosers with allRunModecombinations across Default, InProcessEmit, and InProcessNoEmit toolchainsDisassemblyDiagnoserrefactored as first in-process diagnoser with backward-compatibleRunInHostoptionThe router pattern in
CompositeInProcessDiagnoserHandlercorrectly sequences handlers byRunModeand routes results back via index-based deserialization. Source generation inCodeGenerator.GetInProcessDiagnoserRouters()properly initializes handlers with serialized config.Implementation is production-ready.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.