Skip to content

Conversation

@timcassell
Copy link
Collaborator

@timcassell timcassell commented Oct 22, 2025

Make DisassemblyDiagnoser run in-process by default.
Revert x86 test workaround and add tests.
@timcassell timcassell force-pushed the in-process-diagnosers branch from 83912f1 to 3ad6a27 Compare October 26, 2025 05:36
@timcassell timcassell marked this pull request as ready for review October 26, 2025 22:00
@timcassell timcassell linked an issue Oct 27, 2025 that may be closed by this pull request

This comment was marked as resolved.

@timcassell
Copy link
Collaborator Author

It works nicely, but I'm not entirely sold on this design of diagnosers creating source code tied to C#. An alternative is serializing ctor data. I would love to use static interface members for this, but sadly they aren't supported on netstandard2.0. 😞 @AndreyAkinshin Any thoughts?

@AndreyAkinshin
Copy link
Member

@adamsitnik could you please take a look?

@timcassell
Copy link
Collaborator Author

I changed it so diagnosers return Type and serialized config instead of source code. I think source code generation should be left to the toolchains.

@timcassell timcassell force-pushed the in-process-diagnosers branch from ef14209 to eb27f66 Compare November 1, 2025 22:52
@timcassell
Copy link
Collaborator Author

@copilot Add tests for multiple in-process diagnosers with varying run modes.

Copy link

Copilot AI commented Nov 5, 2025

@timcassell I've opened a new pull request, #2857, to work on those changes. Once the pull request is ready, I'll request review from you.

@timcassell timcassell marked this pull request as draft November 5, 2025 22:26
@timcassell timcassell marked this pull request as ready for review November 8, 2025 18:20
@timcassell

This comment was marked as outdated.

This comment was marked as outdated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

3 participants