fix: Issue that auto-generate JobId is changed between benchmark runs #2777
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndreyAkinshin
approved these changes
Jun 15, 2025
This was referenced Jul 21, 2025
This was referenced Sep 22, 2025
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fix issue that auto-generated JobId is changed every time when launching benchmark process.
Background
Currently
object.GetHashCode()returns different value between runs on .NET Core.It's not seems to be intended behaviors. because generated hash value is used for seed of Random.
And cause diffs when comparing benchmark logs.
This PR modify
JobIdGenerator.csto return same ID between processes.