-
-
Notifications
You must be signed in to change notification settings - Fork 1k
chore: Enable assembly signing for debug build #2774
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Enable assembly signing for debug build #2774
Conversation
|
The current behavior of non-signed Debug builds was introduced in commit 5876f57 on April 12, 2016, by @adamsitnik. I am open to reconsidering this, but I would like to understand the use case better. Why do you want to use the Debug build of BenchmarkDotNet through VS TestExplorer? P.S. BenchmarkDotNet intentionally creates inconveniences to prevent users from running benchmarks with non-optimized assemblies. Therefore, the absence of discovered tests with the Debug version of BenchmarkDotNet seems to be the desired behavior. 🙂 |
adamsitnik
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general the problem you have described is specific to our own solution, as all our customers use the Release builds we ship to nuget.org. But I don't mind improving our dev loop experience of course. Thanks for providing the fix @filzrev!
This PR enable assembly signing for
Debugbuild also.Background
When using
BenchmarkDotNet.TestAdapterand project containsnet462target.net462benchmarks are not shown on TestExplorer withDebugconfiguration.And following error log is recorded on VS output window's
Testspane.Currently BenchmarkDotNet sign assembly on
Releasebuild only.This PR change this behavior to sign
Debugbuild assembly also.What's Tested
BenchmarkDotNet.Samples (net462)benchmarks are shown on TestExplorer