Add net70 runtime support #1816
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
am11
commented
Sep 27, 2021
| @@ -34,7 +34,11 @@ public class CoreRtRuntime : Runtime | |||
| /// <summary> | |||
| /// CoreRT compiled as net6.0 | |||
| /// </summary> | |||
| public static readonly CoreRtRuntime CoreRt60 = new CoreRtRuntime(RuntimeMoniker.CoreRt50, "net6.0", "CoreRT 6.0"); | |||
| public static readonly CoreRtRuntime CoreRt60 = new CoreRtRuntime(RuntimeMoniker.CoreRt60, "net6.0", "CoreRT 6.0"); | |||
There was a problem hiding this comment.
This seemed like a bug so I fixed it.
AndreyAkinshin
approved these changes
Sep 28, 2021
|
@am11 thanks for the PR!
Well, it's not an easy problem. I agree that we have a decent number of different TFMs. However, this set is still maintainable. Meanwhile, hard coded values in API help to easily discover available options. Also they provide a strictly typed way to work with TFMs. @adamsitnik what do you think on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Runtime has switched to net7.0. This PR adds support for 7.0 in BDN.
IMO, we should look into removing hard coded mechanism (enums, --tfm / --cli options etc.). There are just too many redundant moving parts and it is not scaling well.