fix: revert session manager jar location change from PR #29694 (#23631) #29746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spbolton
changed the title
spbolton
changed the title
spbolton
changed the title
nollymar
approved these changes
Aug 23, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Instructions for Log4j require the classes to be added to the system classloader when tomcat loads by adding to the main java CLASSPATH. These logging jars do not need to reference any of the tomcat jars
the session manager jars do need to reference the tomcat jars e.g. catalina.jar in the main lib folder. This is what is called the common.loader and is defined in catalina.properties file.
the session manager jars either need to be in a folder referenced in this common.loader property or as before dropped into the existing lib folder. There is no need to change the old behaviour at this time so we can just change the install location back.
This PR fixes: #23631