feat(logging): create global log4j config (#23631) #29694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spbolton
changed the title
spbolton
force-pushed
the
issue-23631-initial-changes
branch
3 times, most recently
from
f7791d0
to
bb53cf5
Compare
nollymar
approved these changes
Aug 21, 2024
jgambarios
approved these changes
Aug 21, 2024
spbolton
force-pushed
the
issue-23631-initial-changes
branch
from
bb53cf5
to
c1c0d56
Compare
|
jdotcms
approved these changes
Aug 22, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 24, 2024
… (#29746) ### Proposed Changes * Fix classloader issue with session manager introduced in PR #29694 * Use CATALINA_HOME in setenv scripts instead of TOMCAT_HOME. The first is always available, the second is only set within the docker startup scripts Instructions for Log4j require the classes to be added to the system classloader when tomcat loads by adding to the main java CLASSPATH. These logging jars do not need to reference any of the tomcat jars the session manager jars do need to reference the tomcat jars e.g. catalina.jar in the main lib folder. This is what is called the common.loader and is defined in catalina.properties file. the session manager jars either need to be in a folder referenced in this common.loader property or as before dropped into the existing lib folder. There is no need to change the old behaviour at this time so we can just change the install location back.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Issue #23631
As well as using a common configuration for tomcat and webapp logs. This also resolves an inconsistency when The logging class is referenced in code before the ContextLifecycleListener is called. Previously the wrong configuration contained in the resources classpath of the ant-tooling jar was picked up initially.
Tests
Further changes
There is follow up work to this PR that improves the way that the config can be specified and overridden. This change maintains the existing config file behavior but just applies it across the entire application.
Checklist
Additional Info
This PR resolves #23631 (create global log4j config).
Screenshots
This PR fixes: #23631