Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(design system): Update base font size to 14px #28724 #29205

Merged
merged 33 commits into from
Aug 14, 2024
Merged

chore(design system): Update base font size to 14px #28724 #29205

merged 33 commits into from
Aug 14, 2024

Commits on Jul 5, 2024

  1. #28724 updating font variables to match figma design 

    -update $font-size-default to 0.875
-match font-size vars to match figma design
-add $font-size-xxxxl to manage edge cases with 3rem font-size (not in figma)
-replace all the $font-size-smd with the sm one to maintain consistency
-replace all the $font-size-xsm with the xs one to maintain consistency
    @valentinogiardino
    valentinogiardino committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    7823f1d View commit details
    Browse the repository at this point in the history

  2. #28724 replacing 2rem with $font-size-xxxl var

    @valentinogiardino
    valentinogiardino committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    1e7e952 View commit details
    Browse the repository at this point in the history

  3. #28724 fix accesibility on html tags 

    Avoid setting a base font-size
Reference: https://css-tricks.com/accessible-font-sizing-explained/#:~:text=Avoid%20setting%20a%20base%20font,content%20will%20also%20be%20accessible
    @valentinogiardino
    valentinogiardino committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    2ab8cfe View commit details
    Browse the repository at this point in the history

  4. #28724 replace font-size values expressed in rems with vars

    @valentinogiardino
    valentinogiardino committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    14086e3 View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2024

  1. #28724 replace px for vars/rem

    @valentinogiardino
    valentinogiardino committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    d998a16 View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2024

  1. fix missing imports

    @valentinogiardino
    valentinogiardino committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    f21313a View commit details
    Browse the repository at this point in the history

Commits on Jul 17, 2024

  1. fix change datatable rows to 40px height

    @valentinogiardino
    valentinogiardino committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    cd36fd7 View commit details
    Browse the repository at this point in the history

  2. remove comments

    @valentinogiardino
    valentinogiardino committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    138ed94 View commit details
    Browse the repository at this point in the history

Commits on Jul 18, 2024

  1. fix font-size for content-type-form label

    @valentinogiardino
    valentinogiardino committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    bc745b7 View commit details
    Browse the repository at this point in the history

Commits on Jul 29, 2024

  1. remove unnecessary use of !important

    @valentinogiardino
    valentinogiardino committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    0b3b684 View commit details
    Browse the repository at this point in the history

  2. change .cw-rule-engine__empty icon from rem to px

    @valentinogiardino
    valentinogiardino committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    c4e3069 View commit details
    Browse the repository at this point in the history

  3. revert unnecesary font-size definitions on dojoxGrid

    @valentinogiardino
    valentinogiardino committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    fd01963 View commit details
    Browse the repository at this point in the history

  4. fix label font-size to be global in forms

    @valentinogiardino
    valentinogiardino committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    4e8a07d View commit details
    Browse the repository at this point in the history

Commits on Jul 30, 2024

  1. revert icons font-size from rem to px

    @valentinogiardino
    valentinogiardino committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    ac9dc2e View commit details
    Browse the repository at this point in the history

Commits on Aug 2, 2024

  1. add constants at the top of iframe-edit-mode.css.ts that match the na… 

    …mes in the _font.scss
    @valentinogiardino
    valentinogiardino committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    3e875d2 View commit details
    Browse the repository at this point in the history

  2. reset dot-locale-create-edit.component.scss to master

    @valentinogiardino
    valentinogiardino committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    3a2014f View commit details
    Browse the repository at this point in the history

  3. resolve conflict

    @valentinogiardino
    valentinogiardino committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    8a08053 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into issue-28724-ui-update-base-font-size-to-14px

    @valentinogiardino
    valentinogiardino authored Aug 2, 2024
    Configuration menu
    Copy the full SHA
    ca092eb View commit details
    Browse the repository at this point in the history

  5. Update dot-locale-create-edit.component.scss

    @valentinogiardino
    valentinogiardino committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    cba3cbe View commit details
    Browse the repository at this point in the history

  6. fix applied code formatting using yarn nx format:write to resolve f… 

    …ormatting issues
    @valentinogiardino
    valentinogiardino committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    792f4c2 View commit details
    Browse the repository at this point in the history

  7. fix update $font-size-smd

    @valentinogiardino
    valentinogiardino committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    18314f1 View commit details
    Browse the repository at this point in the history

  8. Merge branch 'master' into issue-28724-ui-update-base-font-size-to-14px

    @valentinogiardino
    valentinogiardino authored Aug 2, 2024
    Configuration menu
    Copy the full SHA
    a04c763 View commit details
    Browse the repository at this point in the history

  9. Merge branch 'master' into issue-28724-ui-update-base-font-size-to-14px

    @valentinogiardino
    valentinogiardino authored Aug 2, 2024
    Configuration menu
    Copy the full SHA
    bf1bba5 View commit details
    Browse the repository at this point in the history

Commits on Aug 5, 2024

  1. fix DotBinaryFieldUiMessageComponent test

    @valentinogiardino
    valentinogiardino committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    df21800 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into issue-28724-ui-update-base-font-size-to-14px

    @valentinogiardino
    valentinogiardino authored Aug 5, 2024
    Configuration menu
    Copy the full SHA
    ab84fb9 View commit details
    Browse the repository at this point in the history

Commits on Aug 7, 2024

  1. Merge branch 'master' into issue-28724-ui-update-base-font-size-to-14px

    @valentinogiardino
    valentinogiardino authored Aug 7, 2024
    Configuration menu
    Copy the full SHA
    c2358d3 View commit details
    Browse the repository at this point in the history

Commits on Aug 13, 2024

  1. Merge branch 'master' into issue-28724-ui-update-base-font-size-to-14px

    @valentinogiardino
    valentinogiardino authored Aug 13, 2024
    Configuration menu
    Copy the full SHA
    93133fd View commit details
    Browse the repository at this point in the history

  2. #28724 remove TODO already done

    @valentinogiardino
    valentinogiardino committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    34d36d4 View commit details
    Browse the repository at this point in the history

  3. #28724 use spacing variable

    @valentinogiardino
    valentinogiardino committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    f1df881 View commit details
    Browse the repository at this point in the history

  4. #28724 fix spacing on site browser table

    @valentinogiardino
    valentinogiardino committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    0d7d6a8 View commit details
    Browse the repository at this point in the history

  5. #28724 add $$icon-xl variable to manage 48px font-size icons

    @valentinogiardino
    valentinogiardino committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    d4e7cf6 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'master' into issue-28724-ui-update-base-font-size-to-14px

    @valentinogiardino
    valentinogiardino authored Aug 13, 2024
    Configuration menu
    Copy the full SHA
    f83015c View commit details
    Browse the repository at this point in the history

Commits on Aug 14, 2024

  1. Merge branch 'master' into issue-28724-ui-update-base-font-size-to-14px

    @valentinogiardino
    valentinogiardino authored Aug 14, 2024
    Configuration menu
    Copy the full SHA
    9038f11 View commit details
    Browse the repository at this point in the history