chore(design system): Update base font size to 14px #28724 #29205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-update $font-size-default to 0.875 -match font-size vars to match figma design -add $font-size-xxxxl to manage edge cases with 3rem font-size (not in figma) -replace all the $font-size-smd with the sm one to maintain consistency -replace all the $font-size-xsm with the xs one to maintain consistency
Avoid setting a base font-size Reference: https://css-tricks.com/accessible-font-sizing-explained/#:~:text=Avoid%20setting%20a%20base%20font,content%20will%20also%20be%20accessible
|
|
|
We have tables in: Angular:
Dojo:
|
|
|
zJaaal
changed the title
zJaaal
requested review from
oidacra,
nicobytes,
hmoreras,
rjvelazco and
KevinDavilaDotCMS
fmontes
requested changes
Jul 22, 2024
...app/portlets/shared/dot-content-types-edit/components/form/content-types-form.component.scss
Outdated
Show resolved
Hide resolved
...app/view/components/_common/forms/dot-push-publish-form/dot-push-publish-form.component.scss
Show resolved
Hide resolved
core-web/libs/dotcms-scss/jsp/scss/backend/dot-admin/_dot-admin.scss
Outdated
Show resolved
Hide resolved
hmoreras
reviewed
Jul 31, 2024
...ms-ui/src/app/portlets/dot-edit-page/content/services/html/libraries/iframe-edit-mode.css.ts
Show resolved
Hide resolved
zJaaal
reviewed
Aug 7, 2024
core-web/libs/dotcms-scss/jsp/scss/backend/dot-admin/_dot-admin.scss
Outdated
Show resolved
Hide resolved
rjvelazco
requested changes
Aug 7, 2024
...ms-ui/src/app/portlets/dot-edit-page/content/services/html/libraries/iframe-edit-mode.css.ts
Show resolved
Hide resolved
.../dotcms-ui/src/app/portlets/dot-templates/dot-template-list/dot-template-list.component.html
Show resolved
Hide resolved
core-web/libs/dotcms-scss/angular/dotcms-theme/components/_tree.scss
Outdated
Show resolved
Hide resolved
...libs/portlets/edit-ema/ui/src/lib/dot-seo-image-preview/dot-seo-image-preview.component.scss
Outdated
Show resolved
Hide resolved
|
We only have three icon sizes:
And we have eight font sizes: You can check all sizes here: |
valentinogiardino
requested review from
zJaaal,
KevinDavilaDotCMS and
rjvelazco
zJaaal
approved these changes
Aug 13, 2024
KevinDavilaDotCMS
approved these changes
Aug 13, 2024
|
rjvelazco
approved these changes
Aug 14, 2024
fmontes
approved these changes
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Screenshot
This PR fixes: #28724