-
Notifications
You must be signed in to change notification settings - Fork 467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(edit-content) add search to category-field #28879 #29167
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oidacra
requested review from
nicobytes,
zJaaal,
rjvelazco,
hmoreras and
KevinDavilaDotCMS
July 9, 2024 13:51
nicobytes
reviewed
Jul 9, 2024
.../components/dot-category-field-category-list/dot-category-field-category-list.component.html
Outdated
Show resolved
Hide resolved
...d/components/dot-category-field-search-list/dot-category-field-search-list.component.spec.ts
Outdated
Show resolved
Hide resolved
...-field/components/dot-category-field-search-list/dot-category-field-search-list.component.ts
Outdated
Show resolved
Hide resolved
...-field/components/dot-category-field-search-list/dot-category-field-search-list.component.ts
Outdated
Show resolved
Hide resolved
...t-category-field/components/dot-category-field-search/dot-category-field-search.component.ts
Outdated
Show resolved
Hide resolved
...t-category-field/components/dot-category-field-search/dot-category-field-search.component.ts
Outdated
Show resolved
Hide resolved
...ot-edit-content-category-field/components/dot-table-skeleton/dot-table-skeleton.component.ts
Show resolved
Hide resolved
...ot-edit-content-category-field/components/dot-table-skeleton/dot-table-skeleton.component.ts
Show resolved
Hide resolved
...ot-edit-content-category-field/components/dot-table-skeleton/dot-table-skeleton.component.ts
Outdated
Show resolved
Hide resolved
...category-field/components/dot-category-field-search/dot-category-field-search.component.html
Outdated
Show resolved
Hide resolved
...category-field/components/dot-category-field-sidebar/dot-category-field-sidebar.component.ts
Show resolved
Hide resolved
oidacra
force-pushed
the
issue-28879-search-categoryfield-2
branch
from
July 9, 2024 19:12
57b0fa3
to
5f5f802
Compare
hmoreras
reviewed
Jul 11, 2024
...ield/components/dot-category-field-search-list/dot-category-field-search-list.component.scss
Outdated
Show resolved
Hide resolved
oidacra
force-pushed
the
issue-28879-search-categoryfield-2
branch
from
July 11, 2024 19:48
36fb27a
to
91b378f
Compare
oidacra
force-pushed
the
issue-28879-search-categoryfield-2
branch
3 times, most recently
from
July 12, 2024 15:18
8a25565
to
f3fd1b4
Compare
hmoreras
approved these changes
Jul 12, 2024
oidacra
force-pushed
the
issue-28879-search-categoryfield-2
branch
from
July 12, 2024 19:30
4b7ae27
to
662536e
Compare
rjvelazco
approved these changes
Jul 12, 2024
nicobytes
reviewed
Jul 12, 2024
...ld/components/dot-category-field-category-list/dot-category-field-category-list.component.ts
Show resolved
Hide resolved
...t-category-field/components/dot-category-field-search/dot-category-field-search.component.ts
Outdated
Show resolved
Hide resolved
...t-category-field/components/dot-category-field-search/dot-category-field-search.component.ts
Outdated
Show resolved
Hide resolved
nicobytes
approved these changes
Jul 12, 2024
Quality Gate passedIssues Measures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
categoryfield
Checklist
Additional Info
Screen.Recording.2024-07-09.at.2.53.45.PM.mov
This PR fixes: #28879