Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Search Categories in the Sidebar of Category Field #28879

Closed
Tracked by #28493
oidacra opened this issue Jun 13, 2024 · 3 comments · Fixed by #29167
Closed
Tracked by #28493

Implement Search Categories in the Sidebar of Category Field #28879

oidacra opened this issue Jun 13, 2024 · 3 comments · Fixed by #29167
Assignees
@dsilvam
Labels
QA : Approved Release : 24.07.30 GraphQL Schemas Team : Falcon Type : New Functionality

Comments

@oidacra
Copy link
Member

oidacra commented Jun 13, 2024 •
edited
Loading

Parent Issue

#28493

User Story

As a user, I need to be able to search for categories by their name within the sidebar, so I can quickly find and select the categories I need.

Acceptance Criteria

  • Implement a search input in the sidebar for category names.
  • Allow users to initiate the search by pressing enter or clicking the search (magnifying glass) icon.
  • Display a loading (skeleton) animation while the search results are being fetched.
  • Use PrimeNG components for the search input and results display (if apply).
  • Ensure that search results are accurate and displayed in a user-friendly manner.
  • Follow the Final design of the Figma
  • Write and pass unit tests for the new search functionality.
Screenshot 2024-06-13 at 5 30 58 PM Screenshot 2024-06-13 at 5 30 51 PM

Proposed Objective

User Experience Enhancement

Proposed Priority

Priority 2 - Important

dotCMS Version

master

External Links

Assumptions & Initiation Needs

Assuming the server provides an API endpoint for searching categories by name. Access to design and translation resources is required.

Quality Assurance Notes & Workarounds

Quality assurance should ensure that the search functionality works as expected, search results are accurate, and the loading state is handled correctly. Unit tests should cover the new search functionality.
@oidacra oidacra mentioned this issue Jun 13, 2024
Closed
@oidacra oidacra changed the title Search Categories Implement Search Categories in the Sidebar of Category Field Jun 13, 2024
@oidacra
Copy link
Member Author

oidacra commented Jun 13, 2024

Blocked By #28881

@oidacra oidacra self-assigned this Jul 5, 2024
oidacra added a commit that referenced this issue Jul 8, 2024
@oidacra
feat(edit-content) add search to category-field #28879
4db1e33
oidacra added a commit that referenced this issue Jul 9, 2024
@oidacra
feat(edit-content) unify add and update from search and list #28879
003d6aa
@oidacra oidacra linked a pull request Jul 9, 2024 that will close this issue
feat(edit-content) add search to category-field #28879 #29167
Merged
3 tasks
oidacra added a commit that referenced this issue Jul 9, 2024
@oidacra
feat(edit-content) fix comments #28879
57b0fa3
oidacra added a commit that referenced this issue Jul 9, 2024
@oidacra
feat(edit-content) add search to category-field #28879
e31ffe3
oidacra added a commit that referenced this issue Jul 9, 2024
@oidacra
feat(edit-content) unify add and update from search and list #28879
7745488
oidacra added a commit that referenced this issue Jul 9, 2024
@oidacra
feat(edit-content) fix comments #28879
5f5f802
oidacra added a commit that referenced this issue Jul 11, 2024
@oidacra
feat(edit-content) add search to category-field #28879
38d1e34
oidacra added a commit that referenced this issue Jul 11, 2024
@oidacra
feat(edit-content) unify add and update from search and list #28879
80a0f39
oidacra added a commit that referenced this issue Jul 11, 2024
@oidacra
feat(edit-content) fix comments #28879
19b969f
oidacra added a commit that referenced this issue Jul 11, 2024
@oidacra
feat(edit-content) fix failing tests #28879
c0911ba
oidacra added a commit that referenced this issue Jul 11, 2024
@oidacra
feat(edit-content) fix failing tests #28879
91b378f
oidacra added a commit that referenced this issue Jul 12, 2024
@oidacra
feat(edit-content) add dot-category-field-search-list and dot-categor…
3518da2 
…y-field-search tests #28879
oidacra added a commit that referenced this issue Jul 12, 2024
@oidacra
feat(edit-content) add tests #28879
9fa43cf
oidacra added a commit that referenced this issue Jul 12, 2024
@oidacra
feat(edit-content) add search to category-field #28879
7bfff80
oidacra added a commit that referenced this issue Jul 12, 2024
@oidacra
feat(edit-content) unify add and update from search and list #28879
a3322ba
oidacra added a commit that referenced this issue Jul 12, 2024
@oidacra
feat(edit-content) fix comments #28879
3cd8452
oidacra added a commit that referenced this issue Jul 12, 2024
@oidacra
feat(edit-content) fix failing tests #28879
ac1f3df
oidacra added a commit that referenced this issue Jul 12, 2024
@oidacra
feat(edit-content) fix failing tests #28879
56e90a2
oidacra added a commit that referenced this issue Jul 12, 2024
@oidacra
feat(edit-content) add tests #28879
8a25565
oidacra added a commit that referenced this issue Jul 12, 2024
@oidacra
feat(edit-content) add tests #28879
f3fd1b4
oidacra added a commit that referenced this issue Jul 12, 2024
@oidacra
feat(edit-content) add id and scope to th #28879
24d5a8b
oidacra added a commit that referenced this issue Jul 12, 2024
@oidacra
feat(edit-content) add utility tests #28879
4b7ae27
oidacra added a commit that referenced this issue Jul 12, 2024
@oidacra
feat(edit-content) add search to category-field #28879
8faa841
oidacra added a commit that referenced this issue Jul 12, 2024
@oidacra
feat(edit-content) unify add and update from search and list #28879
37739e5
oidacra added a commit that referenced this issue Jul 12, 2024
@oidacra
feat(edit-content) fix comments #28879
9737e2c
oidacra added a commit that referenced this issue Jul 12, 2024
@oidacra
feat(edit-content) fix failing tests #28879
a36aac6
oidacra added a commit that referenced this issue Jul 12, 2024
@oidacra
feat(edit-content) fix failing tests #28879
8ca24bb
oidacra added a commit that referenced this issue Jul 12, 2024
@oidacra
feat(edit-content) add tests #28879
dfe26c5
oidacra added a commit that referenced this issue Jul 12, 2024
@oidacra
feat(edit-content) add id and scope to th #28879
809b153
oidacra added a commit that referenced this issue Jul 12, 2024
@oidacra
feat(edit-content) add utility tests #28879
662536e
oidacra added a commit that referenced this issue Jul 12, 2024
@oidacra
feat(edit-content) fix merge #28879
3ad8d50
oidacra added a commit that referenced this issue Jul 12, 2024
@oidacra
feat(edit-content) fix comments #28879
2e72fc9
github-merge-queue bot pushed a commit that referenced this issue Jul 12, 2024
@oidacra @nicobytes
feat(edit-content) add search to category-field #28879 (#29167)
430f4c7 
### Proposed Changes
* add search to `categoryfield`


### Checklist
- [x] Tests
- [x] Translations
- [ ] Security Implications Contemplated (add notes if applicable)

### Additional Info


https://github.com/dotCMS/core/assets/1909643/a5e8e8c6-c466-4bf9-aa7d-7a45e6b1b442

---------

Co-authored-by: Nicolas Molina <hi@nicobytes.com>
@github-actions github-actions bot mentioned this issue Jul 12, 2024
Merged
3 tasks
@dsilvam dsilvam assigned dsilvam and unassigned oidacra Jul 17, 2024
@dsilvam
Copy link
Contributor

dsilvam commented Jul 22, 2024

Passed IQA.

  • Was able to search categories throughout the entire tree, including up to 5 levels deep.
  • Search results can be selected and they properly appear on the right sidebar.
  • The searching takes place once you type at least 3 characters.
  • Upon removing the characters by hitting backspace or clicking on the x, the view rests back to the tree.
  • Search results correctly include the Category Path.

@josemejias11
Copy link
Contributor

Approved: Tested on trunk_6417ccd, Docker, macOS 14.5, FF v126.0.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dsilvam dsilvam

Labels
QA : Approved Release : 24.07.30 GraphQL Schemas Team : Falcon Type : New Functionality
Projects
dotCMS - Product Planning
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(edit-content) add search to category-field #28879 dotCMS/core
3 participants
@dsilvam @oidacra @josemejias11