Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(edit-content): Fix the tests for dot-edit-content-field.component.spec #26884 #27429

Merged
merged 6 commits into from
Jan 26, 2024
Merged

chore(edit-content): Fix the tests for dot-edit-content-field.component.spec #26884 #27429

merged 6 commits into from
Jan 26, 2024

Conversation

KevinDavilaDotCMS
Copy link
Contributor

Proposed Changes

  • Now each component inside on EditContentField has its own "DotTestBed", and that have the config to that component, like providers, imports, declarations, props.
  • Now test check "outsided" formControlNames. Most of EditContent components dont need [formControl], but some specific component needs, sot now the test have validation to that special cases (Check if the component have [formControlName] prop)

@KevinDavilaDotCMS KevinDavilaDotCMS linked an issue Jan 25, 2024 that may be closed by this pull request
Edit Content: Fix the tests for dot-edit-content-field.component.spec #26884
Closed
3 tasks
@fmontes fmontes changed the title Refactor on EditContentField tests chore(edit-content): Fix the tests for dot-edit-content-field.component.spec #26884 Jan 25, 2024
@fmontes fmontes added this pull request to the merge queue Jan 25, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 25, 2024
@oidacra oidacra added this pull request to the merge queue Jan 26, 2024
@dotcms-sonarqube dotCMS-sonarqube
Copy link

Quality Gate passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
0.0% 0.0% Coverage on New Code
0.0% 0.0% Duplication on New Code

See analysis details on SonarQube

Merged via the queue into master with commit e5aea27 Jan 26, 2024
17 checks passed
@oidacra oidacra deleted the 26884-edit-content-fix-the-tests-for-dot-edit-content-fieldcomponentspec branch January 26, 2024 02:21
manuelrojas added a commit that referenced this pull request Jan 26, 2024
@KevinDavilaDotCMS @oidacra @manuelrojas
chore(edit-content): Fix the tests for dot-edit-content-field.compone…
09ca895 
…nt.spec #26884 (#27429)

* Refactor on EditContentField tests

* Fix test on Announcements Store

* Fix announcements store test

---------

Co-authored-by: Arcadio Quintero <oidacra@gmail.com>
Co-authored-by: Manuel Rojas <manuel.rojas.21@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oidacra oidacra oidacra approved these changes

@zJaaal zJaaal zJaaal approved these changes

@fmontes fmontes Awaiting requested review from fmontes

@manuelrojas manuelrojas Awaiting requested review from manuelrojas

@rjvelazco rjvelazco Awaiting requested review from rjvelazco

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Edit Content: Fix the tests for dot-edit-content-field.component.spec
4 participants
@KevinDavilaDotCMS @oidacra @zJaaal @manuelrojas