Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Edit Content: Fix the tests for dot-edit-content-field.component.spec #26884

Closed
3 tasks
Tracked by #25445
fmontes opened this issue Dec 5, 2023 · 0 comments · Fixed by #27429
Closed
3 tasks
Tracked by #25445

Edit Content: Fix the tests for dot-edit-content-field.component.spec #26884

fmontes opened this issue Dec 5, 2023 · 0 comments · Fixed by #27429
Assignees
@KevinDavilaDotCMS
Labels
OKR : Core Features Owned by Will Priority : 3 Average QA : Not Needed Team : Lunik Type : Task

Comments

@fmontes
Copy link
Member

fmontes commented Dec 5, 2023 •
edited
Loading

Parent Issue

#25445

Task

The tests are not ok:

  1. Not validating all the inputs
  2. Using real component when we can mock it.
  3. Adding a number of unneeded providers

Proposed Objective

Please Select

Proposed Priority

Please Select

Acceptance Criteria

  • Mock all the components fields.
  • Make sure you test all the inputs and not only "contentlets", we also have field
  • Check if there is a way to assert formControlName

External Links... Slack Conversations, Support Tickets, Figma Designs, etc.

No response

Assumptions & Initiation Needs

No response

Quality Assurance Notes & Workarounds

No response

Sub-Tasks & Estimates

No response
@fmontes fmontes mentioned this issue Dec 6, 2023
Open
@fmontes fmontes removed the Triage label Dec 12, 2023
@KevinDavilaDotCMS KevinDavilaDotCMS self-assigned this Jan 24, 2024
@KevinDavilaDotCMS KevinDavilaDotCMS linked a pull request Jan 25, 2024 that will close this issue
chore(edit-content): Fix the tests for dot-edit-content-field.component.spec #26884 #27429
Merged
github-merge-queue bot pushed a commit that referenced this issue Jan 26, 2024
@KevinDavilaDotCMS @oidacra @manuelrojas
chore(edit-content): Fix the tests for dot-edit-content-field.compone…
e5aea27 
…nt.spec #26884 (#27429)

* Refactor on EditContentField tests

* Fix test on Announcements Store

* Fix announcements store test

---------

Co-authored-by: Arcadio Quintero <oidacra@gmail.com>
Co-authored-by: Manuel Rojas <manuel.rojas.21@gmail.com>
manuelrojas added a commit that referenced this issue Jan 26, 2024
@KevinDavilaDotCMS @oidacra @manuelrojas
chore(edit-content): Fix the tests for dot-edit-content-field.compone…
09ca895 
…nt.spec #26884 (#27429)

* Refactor on EditContentField tests

* Fix test on Announcements Store

* Fix announcements store test

---------

Co-authored-by: Arcadio Quintero <oidacra@gmail.com>
Co-authored-by: Manuel Rojas <manuel.rojas.21@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KevinDavilaDotCMS KevinDavilaDotCMS

Labels
OKR : Core Features Owned by Will Priority : 3 Average QA : Not Needed Team : Lunik Type : Task
Projects
dotCMS - Product Planning
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(edit-content): Fix the tests for dot-edit-content-field.component.spec #26884 dotCMS/core
2 participants
@fmontes @KevinDavilaDotCMS