fix(edit-ema): 🐛 Custom Event select-contentlet is triggering twice on ng-contentlet-selector #26958 #27363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KevinDavilaDotCMS
requested review from
fmontes,
zJaaal,
oidacra,
hmoreras and
rjvelazco
fmontes
requested changes
Jan 18, 2024
core-web/libs/portlets/edit-ema/portlet/src/lib/edit-ema-editor/edit-ema-editor.component.ts
Outdated
Show resolved
Hide resolved
|
zJaaal
approved these changes
Jan 18, 2024
fmontes
approved these changes
Jan 18, 2024
|
YASSSS!!!! |
fmontes
changed the title
fmontes
deleted the
26958-edit-ema-custom-event-select-contentlet-is-triggering-twice-on-ng-contentlet-selector
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Updated video:
Screen.Recording.2024-01-18.at.11.44.45.mov
Note: In the video i show console.logs, but is only for show the problem, console.logs are not in PR
This internal change doesnt break the old edit mode
Screen.Recording.2024-01-18.at.11.59.58.mov