Edit EMA: 🐛 Custom Event select-contentlet is triggering twice on ng-contentlet-selector

[zJaaal]

Parent Issue

#26644

Problem Statement

When selecting a contentlet on contentlet selector, the event is triggering twice, resulting in a double request that ends in an error while saving the new content of the page.

Steps to Reproduce

1. Go to http://localhost:8080/dotAdmin/#/edit-ema be sure that you have an instance of this project running with a valid token and also an active license.
2. Click on the add contentlet button, you should see the ng-contentlet-selector dialog in your screen.
3. Click on the select button of any contenlet. (Optional) If neeed delete all the contentlets until you get to step 4.
4. The table should be empty and your console should have a bad request error (Repeat steps from 1 to 3, until you get here)

Screenshot of the error

Acceptance Criteria

• We should be able to maintain the flow of work, right now the dialog just breaks and we need to reload the page to keep working.
• The dialog should close and the content should be saved without errors.

dotCMS Version

master - latest

Proposed Objective

User Experience

Proposed Priority

Priority 3 - Average

External Links... Slack Conversations, Support Tickets, Figma Designs, etc.

We made some research about this issue. We found out that this is related to the event of the select button being bubbled up to the row, that has the same event. So, it triggers twice, one for the select and one for the Row.

Both events are being handled here:

core/dotCMS/src/main/webapp/html/js/dotcms/dijit/form/ContentSelector.js

Lines 1197 to 1216 in 0b95007

	// Select button functionality
	var selected = function (scope, content) {
	if (this.useRelateContentOnSelect) {
	scope._doRelateContent(content);
	} else {
	scope._onContentSelected(content);
	}
	};
	if (this.multiple == 'false') {
	var asset = cellData;
	var selectRow = dojo.byId('rowId' + i);
	if (selectRow.onclick == undefined) {
	selectRow.onclick = dojo.hitch(
	this,
	selected,
	this,
	asset
	);
	}
	}

core/dotCMS/src/main/webapp/html/js/dotcms/dijit/form/ContentSelector.js

Lines 1282 to 1297 in 0b95007

	if (this.multiple == 'false') {
	for (var i = 0; i < data.length; i++) {
	var asset = data[i];
	var selectButton = dojo.byId(
	this.searchCounter + asset.inode
	);
	if (selectButton.onclick == undefined) {
	selectButton.onclick = dojo.hitch(
	this,
	selected,
	this,
	asset
	);
	}
	}
	}

And both handlers are using the method from here.

We don't have a fix at the moment, that's the reason of this ticket. We need to make further research to be sure of how are we going to solve this and to be sure that the fix should be made in one of those files.

Assumptions & Initiation Needs

No response

Quality Assurance Notes & Workarounds

No response

Sub-Tasks & Estimates

No response