-
Notifications
You must be signed in to change notification settings - Fork 467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dotCMS/core#26520 Add translations to AI Extensions on Block Editor #26871
Merged
oidacra
merged 11 commits into
master
from
issue-26520-implement-translations-on-block-editor
Dec 4, 2023
Merged
dotCMS/core#26520 Add translations to AI Extensions on Block Editor #26871
oidacra
merged 11 commits into
master
from
issue-26520-implement-translations-on-block-editor
Dec 4, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oidacra
force-pushed
the
issue-26520-implement-translations-on-block-editor
branch
from
December 1, 2023 21:22
a46b6f3
to
36b21d5
Compare
oidacra
requested review from
fmontes,
hmoreras,
rjvelazco,
manuelrojas,
zJaaal and
KevinDavilaDotCMS
December 1, 2023 21:25
hmoreras
approved these changes
Dec 1, 2023
zJaaal
approved these changes
Dec 4, 2023
oidacra
force-pushed
the
issue-26520-implement-translations-on-block-editor
branch
from
December 4, 2023 15:34
d30e4c9
to
8f28284
Compare
oidacra
force-pushed
the
issue-26520-implement-translations-on-block-editor
branch
from
December 4, 2023 16:48
8f28284
to
ceef948
Compare
Quality Gate passedThe SonarQube Quality Gate passed, but some issues were introduced. 1 New issue |
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
oidacra
deleted the
issue-26520-implement-translations-on-block-editor
branch
December 4, 2023 21:31
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Checklist
Description
🤖[deprecated] Generated by Copilot at 36b21d5
The pull request adds and updates components, services, and templates for the block editor module and its extensions. It also uses the
DotMessageService
and thedm
pipe to provide localization for the texts in the block editor UI. Additionally, it modifies theDotAiService
interface and its mock implementation to match the changes in the API. Finally, it adds the message keys and values for the block editor extension to theLanguage.properties
file.Related Issue
Fixes #26520
Explanation of Changes
🤖[deprecated] Generated by Copilot at 36b21d5
app.module.ts
(link,link)APP_INITIALIZER
token and use it to initializeDotMessageService
before app starts inblock-editor.module.ts
(link,link)BubbleFormComponent
andFloatingButtonComponent
todeclarations
andentryComponents
arrays ofblock-editor.module.ts
to register and create them as custom elements (link,link)EditorDirective
fromdeclarations
toshared
folder and exportDotMessagePipe
fromblock-editor.module.ts
(link,link)middleware.js
code inapp.module.ts
(link)DotMessageService
and use it to get message values foractionOptions
array inAIContentActionsComponent
(link,link,link,link)dm
pipe to display message values forplaceholder
,icon
,header
,label
, andmessage
attributes in component templates (link,link,link,link,link,link,link,link,link)DotMessagePipe
and add it toproviders
array ofAIImagePromptComponent
(link,link)DotMessageServiceMock
class to provide mock messages for testing (link)getIAContent
method togenerateContent
and change return type toObservable<string>
inDotAiService
interface and mock class (link,link)Language.properties
file indotCMS
project (link)dot-messages.service.ts
(link,link)