Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UI] Add DotMessageService to Block Editor to able translate the labels/messages #26520

Closed
Tracked by #26495
oidacra opened this issue Oct 25, 2023 · 4 comments · Fixed by #26871
Closed
Tracked by #26495

[UI] Add DotMessageService to Block Editor to able translate the labels/messages #26520

oidacra opened this issue Oct 25, 2023 · 4 comments · Fixed by #26871
Assignees
@oidacra
Labels
dotCMS : AI QA : Not Needed Team : Falcon Type : Task

Comments

@oidacra
Copy link
Member

oidacra commented Oct 25, 2023 •
edited by hmoreras
Loading

Parent Issue

User Story

Translations do not exist in block editor.

Acceptance Criteria

Add the ability to translate strings. in block editor.

dotCMS Version

master

Proposed Objective

to_define

Proposed Priority

to_define

External Links... Slack Conversations, Support Tickets, Figma Designs, etc.

to_define

Assumptions & Initiation Needs

to_define

Quality Assurance Notes & Workarounds

to_define

Sub-Tasks & Estimates
@oidacra oidacra mentioned this issue Oct 25, 2023
Closed
@john-thomas-dotcms
Copy link
Contributor

Some work was already done to make the strings used by the AI plugin translatable. But the actual translations weren't performed.

So, we need to ensure that the translations are actually performed, and the translated strings are available in the right place for them to show up in the BE. The way this should be done is that the Language variables with the translations should be added by the plugin when it loads; the code to do this should exist already in the plugin.

@oidacra
Copy link
Member Author

oidacra commented Nov 16, 2023

Block Editor does not have the service for translations. This will be the first time using BE translations in Block Editor..

@oidacra oidacra changed the title [UI] Add translations to AIContentPromptExtension [UI] Add DotMessageService to Block Editor to able translate the labels/messages Nov 16, 2023
@oidacra oidacra mentioned this issue Nov 16, 2023
Closed
@john-thomas-dotcms
Copy link
Contributor

We do not need to support translation of content in the AI block. We need to support translation of the strings the AI blocks use (meaning the labels on the fields in the popup).

@oidacra
Copy link
Member Author

oidacra commented Nov 16, 2023

Correct. That is the main. Labels, error messages, name of menu.

@oidacra oidacra self-assigned this Nov 30, 2023
oidacra added a commit that referenced this issue Dec 1, 2023
@oidacra
feat(block-editor) #26520 added dotMessageService to Block Editor
f7f5b20
oidacra added a commit that referenced this issue Dec 1, 2023
@oidacra
feat(block-editor) #26520 added translations to Language.properties
9d2b281
@oidacra oidacra mentioned this issue Dec 1, 2023
Merged
3 tasks
oidacra added a commit that referenced this issue Dec 1, 2023
@oidacra
feat(block-editor) #26520 added dotMessageService to Block Editor
0c04047
oidacra added a commit that referenced this issue Dec 1, 2023
@oidacra
feat(block-editor) #26520 added translations to Language.properties
c161807
oidacra added a commit that referenced this issue Dec 4, 2023
@oidacra
feat(block-editor) #26520 added dotMessageService to Block Editor
4490d7a
oidacra added a commit that referenced this issue Dec 4, 2023
@oidacra
feat(block-editor) #26520 added translations to Language.properties
017268e
github-merge-queue bot pushed a commit that referenced this issue Dec 4, 2023
@oidacra
#26520 Add translations to AI Extensions on Block Editor (#26871)
1814d9e 
* 26551 UI `AiImagePromptInputComponent` done

* 26551 UI `AiImagePromptInputComponent` fixes

* 26551 UI `AiImagePromptInputComponent` remove unnused code

* issue-26551 fix comments

* feat(block-editor) added dotMessageService to BlockEditor

* feat(block-editor) #26520 added dotMessageService to Block Editor

* feat(block-editor) #26520 added translations to Language.properties

* feat(ai-image-prompt): add pipe to translate strings

* fix: failing test

* fix: failing test
oidacra added a commit that referenced this issue Dec 8, 2023
@oidacra
feat(block-editor) #26520 fix
25889bb
oidacra added a commit that referenced this issue Dec 8, 2023
@oidacra
feat(block-editor) #26520 fix
28ec67e
oidacra added a commit that referenced this issue Dec 8, 2023
@oidacra
feat(block-editor) #26520 fix tests
b8b17c4
github-merge-queue bot pushed a commit that referenced this issue Dec 8, 2023
@oidacra
#26520 Fix how works DotMessageService (#26893)
f5a29f5 
* (block-editor) fix how works DotMessageService

* (block-editor) take in consideration lang

* feat(block-editor) #26520 fix tests
erickgonzalez added a commit that referenced this issue Feb 23, 2024
@erickgonzalez
#26520 include in 23.10.24
ec6f42b
erickgonzalez added a commit that referenced this issue Feb 23, 2024
@erickgonzalez
#26520 include in 23.10.24
5dab6cb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oidacra oidacra

Labels
dotCMS : AI QA : Not Needed Team : Falcon Type : Task
Projects
dotCMS - Product Planning
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

dotCMS/core#26520 Add translations to AI Extensions on Block Editor dotCMS/core
2 participants
@oidacra @john-thomas-dotcms