fix: correct repository extraction for mirror registries #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous logic was performing two extractions which resulted in removing too much from the repository path. For mirror.gcr.io/dotcms/dotcms, it was extracting 'dotcms' instead of 'dotcms/dotcms'. Changed to single extraction that removes only the registry domain prefix, preserving the org/repo structure. Before: mirror.gcr.io/dotcms/dotcms → dotcms (❌ incorrect) After: mirror.gcr.io/dotcms/dotcms → dotcms/dotcms (✅ correct)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the repository extraction logic that was incorrectly removing too much from mirror registry paths.
Problem
The previous logic performed two extractions:
mirror.gcr.io/dotcms/dotcms→dotcms/dotcms(remove registry)dotcms/dotcms→dotcms(remove one more level)This caused validation failures because
dotcmsdoes not match the allowed repositorydotcms/dotcms.Solution
Changed to a single extraction that removes only the registry domain prefix, preserving the org/repo structure.
Test Results
mirror.gcr.io/dotcms/dotcms→dotcms/dotcmsdocker.io/dotcms/dotcms→dotcms/dotcmsdotcms/dotcms→dotcms/dotcmsImpact
This fix enables proper validation of images from mirror registries like
mirror.gcr.io.Related