fix: correct image format regex to support underscores in tags #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous regex pattern [a-zA-Z0-9._-] had the hyphen in a position that caused it to be interpreted as a range operator, preventing tags with underscores (like 25.12.08-1_872913a) from matching. Changed character class order to [a-zA-Z0-9_.-] to fix the issue. This enables proper validation of immutable tags with commit hashes.
dcolina
added a commit
that referenced
this pull request
Dec 12, 2025
## Summary Fixes the repository extraction logic that was incorrectly removing too much from mirror registry paths. ## Problem The previous logic performed two extractions: 1. `mirror.gcr.io/dotcms/dotcms` → `dotcms/dotcms` (remove registry) 2. `dotcms/dotcms` → `dotcms` (remove one more level) This caused validation failures because `dotcms` does not match the allowed repository `dotcms/dotcms`. ## Solution Changed to a single extraction that removes only the registry domain prefix, preserving the org/repo structure. ### Test Results - ✅ `mirror.gcr.io/dotcms/dotcms` → `dotcms/dotcms` - ✅ `docker.io/dotcms/dotcms` → `dotcms/dotcms` - ✅ `dotcms/dotcms` → `dotcms/dotcms` ## Impact This fix enables proper validation of images from mirror registries like `mirror.gcr.io`. ## Related - Blocks: dotCMS/deutschebank-infrastructure#360 - Follows: #13
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the image format validation regex that was preventing tags with underscores (like commit hashes) from being validated correctly.
Problem
The regex pattern had the hyphen positioned in a way that caused validation failures for images like mirror.gcr.io/dotcms/dotcms:25.12.08-1_872913a
Solution
Changed the character class order from [a-zA-Z0-9.-] to [a-zA-Z0-9.-] to ensure the hyphen is interpreted as a literal character.
Testing
Local verification confirms the fix works with tags containing underscores and hashes.
Impact
This enables the deployment guard to properly validate Docker images with commit hash suffixes (v1.1.1 feature).