Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing SPFSyntaxError when ip address and version are not matching #87

Merged
merged 1 commit into from
Dec 18, 2022

Conversation

stcz
Copy link
Contributor

@stcz stcz commented Dec 13, 2022

Currently, the parse_spf_record function doesn't detect when a IPv4 Address is written in the ip6 mechanism and the other way round. This MR will fix this behavior.

@seanthegeek seanthegeek merged commit 1d74366 into domainaware:master Dec 18, 2022
seanthegeek added a commit that referenced this pull request Dec 20, 2022
- Detect non-trivial loops (PR [#88](#88))
- Raise a `SPFSyntaxError` exception when an IP address and IP version do not match (PR [#87](#87))
- Fix raising the `DMARCRecordNotFound` exception when a DMARC record does not exist (PR [#86](#86) closes issue [#72](#72))
- Add void lookup limit (PR [#85](#85))
- Add Support for User Defined DNS Resolver Object (PR [#83](#83))
@stcz stcz deleted the fix_ip4-6_mismatch branch December 27, 2022 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants