Add Support for User Defined DNS Resolver Object #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanthegeek
requested changes
Oct 28, 2022
There was a problem hiding this comment.
Please break up the liness listed below to stay within the line lengths required by the PEP8 standard
checkdmarc.py:619:80: E501 line too long (81 > 79 characters)
checkdmarc.py:628:80: E501 line too long (83 > 79 characters)
checkdmarc.py:676:80: E501 line too long (83 > 79 characters)
checkdmarc.py:690:80: E501 line too long (86 > 79 characters)
checkdmarc.py:708:80: E501 line too long (83 > 79 characters)
checkdmarc.py:722:80: E501 line too long (86 > 79 characters)
checkdmarc.py:747:80: E501 line too long (83 > 79 characters)
checkdmarc.py:761:80: E501 line too long (91 > 79 characters)
checkdmarc.py:785:80: E501 line too long (83 > 79 characters)
checkdmarc.py:794:80: E501 line too long (87 > 79 characters)
checkdmarc.py:811:80: E501 line too long (83 > 79 characters)
checkdmarc.py:822:80: E501 line too long (87 > 79 characters)
checkdmarc.py:842:80: E501 line too long (83 > 79 characters)
checkdmarc.py:854:80: E501 line too long (87 > 79 characters)
checkdmarc.py:900:80: E501 line too long (82 > 79 characters)
checkdmarc.py:909:80: E501 line too long (83 > 79 characters)
checkdmarc.py:921:80: E501 line too long (87 > 79 characters)
checkdmarc.py:973:80: E501 line too long (83 > 79 characters)
checkdmarc.py:993:80: E501 line too long (84 > 79 characters)
checkdmarc.py:1007:80: E501 line too long (93 > 79 characters)
checkdmarc.py:1018:80: E501 line too long (82 > 79 characters)
checkdmarc.py:1027:80: E501 line too long (83 > 79 characters)
checkdmarc.py:1047:80: E501 line too long (91 > 79 characters)
checkdmarc.py:1159:80: E501 line too long (83 > 79 characters)
checkdmarc.py:1197:80: E501 line too long (82 > 79 characters)
checkdmarc.py:1206:80: E501 line too long (83 > 79 characters)
checkdmarc.py:1223:80: E501 line too long (97 > 79 characters)
checkdmarc.py:1274:80: E501 line too long (83 > 79 characters)
checkdmarc.py:1395:80: E501 line too long (95 > 79 characters)
checkdmarc.py:1398:80: E501 line too long (91 > 79 characters)
checkdmarc.py:1435:80: E501 line too long (95 > 79 characters)
checkdmarc.py:1438:80: E501 line too long (91 > 79 characters)
checkdmarc.py:1491:80: E501 line too long (93 > 79 characters)
checkdmarc.py:1500:80: E501 line too long (83 > 79 characters)
checkdmarc.py:1523:80: E501 line too long (82 > 79 characters)
checkdmarc.py:1530:80: E501 line too long (90 > 79 characters)
checkdmarc.py:1545:80: E501 line too long (83 > 79 characters)
checkdmarc.py:1561:80: E501 line too long (97 > 79 characters)
checkdmarc.py:1577:80: E501 line too long (87 > 79 characters)
checkdmarc.py:1605:80: E501 line too long (94 > 79 characters)
checkdmarc.py:1617:80: E501 line too long (83 > 79 characters)
checkdmarc.py:1696:80: E501 line too long (93 > 79 characters)
checkdmarc.py:1708:80: E501 line too long (91 > 79 characters)
checkdmarc.py:1730:80: E501 line too long (98 > 79 characters)
checkdmarc.py:1735:80: E501 line too long (91 > 79 characters)
checkdmarc.py:1767:80: E501 line too long (97 > 79 characters)
checkdmarc.py:1772:80: E501 line too long (90 > 79 characters)
checkdmarc.py:1817:80: E501 line too long (83 > 79 characters)
checkdmarc.py:1831:80: E501 line too long (98 > 79 characters)
checkdmarc.py:1833:80: E501 line too long (96 > 79 characters)
checkdmarc.py:2083:80: E501 line too long (83 > 79 characters)
checkdmarc.py:2100:80: E501 line too long (82 > 79 characters)
checkdmarc.py:2137:80: E501 line too long (90 > 79 characters)
checkdmarc.py:2154:80: E501 line too long (92 > 79 characters)
checkdmarc.py:2217:80: E501 line too long (83 > 79 characters)
checkdmarc.py:2228:80: E501 line too long (85 > 79 characters)
checkdmarc.py:2301:80: E501 line too long (83 > 79 characters)
checkdmarc.py:2368:80: E501 line too long (85 > 79 characters)
checkdmarc.py:2389:80: E501 line too long (88 > 79 characters)
seanthegeek
approved these changes
Dec 18, 2022
seanthegeek
added a commit
that referenced
this pull request
Dec 20, 2022
- Detect non-trivial loops (PR [#88](#88)) - Raise a `SPFSyntaxError` exception when an IP address and IP version do not match (PR [#87](#87)) - Fix raising the `DMARCRecordNotFound` exception when a DMARC record does not exist (PR [#86](#86) closes issue [#72](#72)) - Add void lookup limit (PR [#85](#85)) - Add Support for User Defined DNS Resolver Object (PR [#83](#83))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR allows passing a user defined resolver object (
dns.resolver.Resolver()) to the DNS Requests. This is useful, when you use functions, and you want to pass special options to the resolver object.The Settings
timeoutandnameserversare ignored, when a resolver is given.Please review or comment. I just tested it in my use case, but tried to adapt for all use cases.
I'm currently unsure how to handle the
test_dnssec()function, especially thedns.query.udp()for me, it is OK to ignore it.