Skip to content

disable query diff #1321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 10, 2021
Merged

disable query diff #1321

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9514fc6
disable query diff
Feb 10, 2021
c79c1dc
delete unused code. can recover from source control later
Feb 10, 2021
b48a985
remove query diff bats tests
Feb 10, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
71 changes: 0 additions & 71 deletions bats/query-diff.bats
View file
Open in desktop

This file was deleted.

6 changes: 0 additions & 6 deletions go/cmd/dolt/commands/diff.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,6 @@ func (cmd DiffCmd) createArgParser() *argparser.ArgParser {
ap.SupportsString(FormatFlag, "r", "result output format", "How to format diff output. Valid values are tabular & sql. Defaults to tabular. ")
ap.SupportsString(whereParam, "", "column", "filters columns based on values in the diff. See {{.EmphasisLeft}}dolt diff --help{{.EmphasisRight}} for details.")
ap.SupportsInt(limitParam, "", "record_count", "limits to the first N diffs.")
ap.SupportsString(QueryFlag, "q", "query", "diffs the results of a query at two commits")
ap.SupportsFlag(CachedFlag, "c", "Show only the unstaged data changes.")
return ap
}
Expand All @@ -161,11 +160,6 @@ func (cmd DiffCmd) Exec(ctx context.Context, commandStr string, args []string, d
return HandleVErrAndExitCode(errhand.VerboseErrorFromError(err), usage)
}

if dArgs.query != "" {
verr := diffQuery(ctx, dEnv, fromRoot, toRoot, dArgs.query)
return HandleVErrAndExitCode(verr, usage)
}

verr := diffUserTables(ctx, fromRoot, toRoot, dArgs)

if verr != nil {
Expand Down
175 changes: 0 additions & 175 deletions go/cmd/dolt/commands/query_diff.go
View file
Open in desktop

This file was deleted.

Loading