Skip to content

Conversation

@bheni
Copy link
Contributor

@bheni bheni commented Feb 10, 2021

query diff was a little known feature that was not well documented and was the source of a large amount of maintenance work. We can recover this from git in the future, or reimplement once it is a priority.

@reltuk
Copy link
Contributor

reltuk commented Feb 10, 2021

Is it worth leaving in a bunch of untested dead code? Likely to rot more and more over time?

@bheni
Copy link
Contributor Author

bheni commented Feb 10, 2021

Is it worth leaving in a bunch of untested dead code? Likely to rot more and more over time?

deleted it.

Copy link
Contributor

@reltuk reltuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bheni bheni merged commit 96a3fd2 into master Feb 10, 2021
@bheni bheni deleted the bh/disable-query-diff branch February 10, 2021 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants