Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix non-object functional child case for modifying wrapped children i… #852

Merged
merged 1 commit into from
Oct 21, 2020

Conversation

rorticus
Copy link
Contributor

…n test renders (#851)

Type: bug / feature

Backport of 2d95a68 to v7

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit e225cf7:

Sandbox Source
dojo/dojo-codesandbox-template Configuration

@codecov
Copy link

codecov bot commented Oct 21, 2020

Codecov Report

Merging #852 into v7 will increase coverage by 0.04%.
The diff coverage is 98.35%.

Impacted file tree graph

@@            Coverage Diff             @@
##               v7     #852      +/-   ##
==========================================
+ Coverage   97.52%   97.57%   +0.04%     
==========================================
  Files         126      126              
  Lines        7933     7951      +18     
  Branches     1826     1833       +7     
==========================================
+ Hits         7737     7758      +21     
+ Misses        196      193       -3     
Impacted Files Coverage Δ
src/core/middleware/resources.ts 98.56% <97.32%> (+<0.01%) ⬆️
src/core/middleware/icache.ts 100.00% <100.00%> (ø)
src/core/vdom.ts 97.99% <100.00%> (+<0.01%) ⬆️
src/testing/decorate.ts 98.01% <100.00%> (+0.01%) ⬆️
src/testing/harness/harness.ts 93.87% <100.00%> (+2.04%) ⬆️
src/testing/renderer.ts 97.69% <100.00%> (+0.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c9b5b7...e225cf7. Read the comment docs.

@rorticus rorticus merged commit 1904033 into dojo:v7 Oct 21, 2020
@rorticus rorticus deleted the v7-harness-fix branch October 21, 2020 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants