Fix non-object functional child case for modifying wrapped children i…

…n test renders (#851) (#852)

Co-authored-by: Bradley Maier <bmaier@sitepen.com>

src/testing/decorate.ts

@@ -83,7 +83,16 @@ export function decorate(actual: RenderResult, expected: RenderResult, instructi
 						const expectedChild: any = expectedNode.children && expectedNode.children[0];
 						const actualChild: any = isNode(actualNode) && actualNode.children && actualNode.children[0];
 
-						if (typeof expectedChild === 'object') {
+						if (typeof expectedChild === 'function' || typeof actualChild === 'function') {
+							if (typeof expectedChild === 'function') {
+								const newExpectedChildren = expectedChild();
+								(expectedNode as any).children[0] = newExpectedChildren;
+							}
+							if (typeof actualChild === 'function') {
+								const newActualChildren = actualChild(...instruction.params);
+								(actualNode as any).children[0] = newActualChildren;
+							}
+						} else if (typeof expectedChild === 'object') {
 							const keys = Object.keys(expectedChild);
 							for (let i = 0; i < keys.length; i++) {
 								const key = keys[i];
@@ -96,13 +105,6 @@ export function decorate(actual: RenderResult, expected: RenderResult, instructi
 									actualChild[key] = newActualChildren;
 								}
 							}
-						} else if (typeof expectedChild === 'function') {
-							const newExpectedChildren = expectedChild();
-							(expectedNode as any).children[0] = newExpectedChildren;
-							if (typeof actualChild === 'function') {
-								const newActualChildren = actualChild(...instruction.params);
-								(actualNode as any).children[0] = newActualChildren;
-							}
 						}
 					} else if (
 						instruction.type === 'property' &&

src/testing/renderer.ts

@@ -111,6 +111,11 @@ function findNode<T extends Wrapped<any>>(renderResult: RenderResult, wrapped: T
 		}
 		if (isVNode(node) || isWNode(node)) {
 			const children = node.children || [];
+			for (let i = 0; i < children.length; i++) {
+				if (typeof children[i] === 'function') {
+					children[i] = (children[i] as any)();
+				}
+			}
 			nodes = [...children, ...nodes];
 		} else if (node && typeof node === 'object') {
 			nodes = [

tests/testing/unit/assertRender.tsx

@@ -46,8 +46,8 @@ class WidgetWithMap extends WidgetBase {
 }
 
 function getExpectedError() {
-	const mockWidgetName = (MockWidget as any).name || 'Widget-5';
-	const widgetWithChildrenName = (MockWidget as any).name ? 'WidgetWithNamedChildren' : 'Widget-6';
+	const mockWidgetName = (MockWidget as any).name || 'Widget-6';
+	const widgetWithChildrenName = (MockWidget as any).name ? 'WidgetWithNamedChildren' : 'Widget-7';
 	return `
 <div
 (A)	classes={["one","two","three"]}

tests/testing/unit/assertion.tsx

@@ -219,6 +219,25 @@ describe('new/assertion', () => {
 	});
 
 	it('can set a child of a functional child widget', () => {
+		const AWidget = create().children<{ (): RenderResult }>()(({ children }) => <div>{children()[0]()}</div>);
+		const ParentWidget = create()(() => (
+			<div>
+				<AWidget>{() => <div>bar</div>}</AWidget>
+			</div>
+		));
+		const WrappedWidget = wrap(AWidget);
+		const r = renderer(() => <ParentWidget />);
+		r.child(WrappedWidget, { foo: [] });
+		const WrappedDiv = wrap('div');
+		const testAssertion = assertion(() => (
+			<div>
+				<WrappedWidget>{() => <WrappedDiv>foo</WrappedDiv>}</WrappedWidget>
+			</div>
+		));
+		r.expect(testAssertion.setChildren(WrappedDiv, () => ['bar']));
+	});
+
+	it('can set a child of a functional child widget that is a property on an object', () => {
 		const AWidget = create().children<{ bar: RenderResult; foo(): RenderResult }>()(({ children }) => (
 			<div>
 				{children()[0].foo()}