Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the same css module ident for all builds #39

Closed
bryanforbes opened this issue Sep 5, 2018 · 0 comments
Closed

Use the same css module ident for all builds #39

bryanforbes opened this issue Sep 5, 2018 · 0 comments
Assignees
@bryanforbes
Labels
bug Something isn't working next Issue/Pull Request for the next major version

Comments

@bryanforbes
Copy link
Member

We currently have a more verbose ident for dev that includes the filename, this causes problems when writing functional tests as the selectors change between modes, and the test bundle (which would contain the target selectors) currently uses the dist selectors.

Their is no harm in using the more verbose ident for all modes as the bundle size after gzip or related compression is likely no different.

Related to dojo/cli-build-app#154
@bryanforbes bryanforbes added bug Something isn't working next Issue/Pull Request for the next major version labels Sep 5, 2018
@bryanforbes bryanforbes self-assigned this Sep 5, 2018
@bryanforbes bryanforbes mentioned this issue Sep 5, 2018
Merged
bryanforbes added a commit that referenced this issue Sep 6, 2018
@bryanforbes
Use a consistent css ident between build profiles (#40)
8ffeb89 
Resolves #39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bryanforbes bryanforbes

Labels
bug Something isn't working next Issue/Pull Request for the next major version
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bryanforbes