Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the same css module ident for all builds #154

Closed
matt-gadd opened this issue Aug 31, 2018 · 0 comments
Closed

Use the same css module ident for all builds #154

matt-gadd opened this issue Aug 31, 2018 · 0 comments
Assignees
@bryanforbes
Labels
bug next Issue/Pull Request for the next major version

Comments

@matt-gadd
Copy link
Contributor

We currently have a more verbose ident for dev that includes the filename, this causes problems when writing functional tests as the selectors change between modes, and the test bundle (which would contain the target selectors) currently uses the dist selectors.

Their is no harm in using the more verbose ident for all modes as the bundle size after gzip or related compression is likely no different.
@matt-gadd matt-gadd added bug next Issue/Pull Request for the next major version labels Aug 31, 2018
@bryanforbes bryanforbes self-assigned this Sep 5, 2018
@bryanforbes bryanforbes mentioned this issue Sep 5, 2018
Closed
bryanforbes added a commit to bryanforbes/cli-build-app that referenced this issue Sep 5, 2018
@bryanforbes
Use a consistent css ident between build profiles
c039e56 
Fixes dojo#154
@bryanforbes bryanforbes mentioned this issue Sep 5, 2018
Merged
bryanforbes added a commit that referenced this issue Sep 6, 2018
@bryanforbes
Use a consistent css ident between build profiles (#161)
fccdd6f 
Fixes #154
@snyk-bot snyk-bot mentioned this issue Nov 18, 2020
Open
@snyk-bot snyk-bot mentioned this issue May 17, 2021
Open
This was referenced May 25, 2021
Open
Open
@snyk-bot snyk-bot mentioned this issue Jun 26, 2021
Open
@snyk-bot snyk-bot mentioned this issue Sep 18, 2021
Open
@Matthelonianxl Matthelonianxl mentioned this issue Oct 2, 2023
Open
@Matthelonianxl Matthelonianxl mentioned this issue Nov 27, 2023
Open
@Matthelonianxl Matthelonianxl mentioned this issue Dec 20, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bryanforbes bryanforbes

Labels
bug next Issue/Pull Request for the next major version
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bryanforbes @matt-gadd