-
Notifications
You must be signed in to change notification settings - Fork 24
SF4 and php7 mods #13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This reverts commit bc0d015.
Thanks @w473 We're running php7.1 here but we don't have your addition:
We do have this in our main app
perhaps that's all you need for php7? Could you submit another PR with just the sf4 changes or change this one to have just sf4? If you think we still need php7 changes, please submit another PR just for that so we can review separately. Thanks again for helping. |
I will check this evening your suggestions. But to make it work I need info about ext-mongo for php7 and I need php7.1 for sf4 |
So I've rechecked everything and it looks like its required to install mapper for old mongo lib: |
The build is failing because of this : if [ "x${ADAPTER_VERSION}" != "x" ]; then composer require "alcaeus/mongo-php-adapter=${ADAPTER_VERSION}" --ignore-platform-reqs; fi. We have to update the build script. |
@w473 do you mind just updating the PR with master so we can get the travis tests running, then we should be good to go |
still issues...:
|
We should just ignore 5.3 and drop builds for it as Symfony 4 does not even install on PHP 5.3. |
well this should work with older version of symfony, but supporting now anything below php 5.6 is somehow strange for me |
I've made release We can merge this one into Then we can remove |
On merge this PR's build has passed |
#16 opened to remove |
Thanks for helping @w473 I've tagged a |
thx, I will check it tomorrow |
works properly THX! |
Modification to make it work with php7 and symfony 4
NOT TESTED with previous versions