SF4 and php7 mods #8
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
redthor
reviewed
Feb 13, 2018
| "symfony/framework-bundle": "~2.1|^3.0", | ||
| "doesntmattr/mongodb-migrations": "^1.1", | ||
| "symfony/framework-bundle": "~2.1|^3.0|^4", | ||
| "doesntmattr/mongodb-migrations": "^1.1|dev-master", |
There was a problem hiding this comment.
@w473
dev-master makes me a little nervous, I think we would likely have a 1.2 with your mongodb-migrations changes ( doesntmattr/mongodb-migrations#13 ) and ^1.1 will include it..
|
I left it like this after my local test so both PRs would work together. I will then decline this one and wait for other to finish |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modification to make it work with php7 and symfony 4
NOT TESTED with previous versions