Skip to content

Remove PersistentObject magic object.#51

Merged
jwage merged 1 commit intomasterfrom
remove-persistent-object
Apr 18, 2019
Merged

Remove PersistentObject magic object.#51
jwage merged 1 commit intomasterfrom
remove-persistent-object

Conversation

@jwage
Copy link
Member

@jwage jwage commented Apr 17, 2019

PersistentObject was initially introduced to show that you can do ActiveRecord with Doctrine components.

Its usage has never been endorsed, and objects "saving themselves" are mostly an idea that is better implemented in other tools that focus just on that, while the Doctrine organization mostly focuses on mappers.

If somebody needs this, it will be trivial for them to re-implement this in their own domain, but we shouldn't push it forward from our end.

PR to deprecate this functionality in 1.2 first can be found here #55

@jwage jwage added this to the 2.0 milestone Apr 17, 2019
@jwage jwage force-pushed the remove-persistent-object branch from 44e3798 to 355b1f8 Compare April 17, 2019 22:04
@ostrolucky
Copy link
Member

"Why" is needed

@Ocramius
Copy link
Member

@ostrolucky here's my attempt to clear up the "why":

PersistentObject was initially designed as a stunt by @beberlei to show that "yes, you can do ActiveRecord even with Doctrine components".

Its usage has never been endorsed, and objects "saving themselves" are mostly an idea that is better implemented in other tools that focus just on that, while the Doctrine organisation mostly focuses on mappers.

If somebody needs this, it will be trivial for them to re-implement this in their own domain, but we shouldn't push it forward from our end.

@ostrolucky
Copy link
Member

Thanks, that's all everybody out of the loop needs

Copy link
Member

@ostrolucky ostrolucky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UPGRADE document should be created mentioning removal of this. I agree with UPGRADE-MAJOR.md convention mentioned here #47 (comment) And deprecation for 1.2 branch should be merged first

@jwage jwage force-pushed the remove-persistent-object branch 2 times, most recently from 5a9afbc to 30f68ba Compare April 18, 2019 16:00
@jwage jwage force-pushed the remove-persistent-object branch from 30f68ba to b36fcdc Compare April 18, 2019 16:03
@jwage
Copy link
Member Author

jwage commented Apr 18, 2019

@ostrolucky PR to add deprecation to 1.2 here #55

@jwage jwage added the BC Break label Apr 18, 2019
@jwage jwage requested a review from ostrolucky April 18, 2019 16:28
@jwage jwage merged commit a46388a into master Apr 18, 2019
@jwage jwage deleted the remove-persistent-object branch April 18, 2019 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants