Deprecate ObjectManager::merge() and ObjectManager::detach()#47
Closed
Majkl578 wants to merge 1 commit intodoctrine:1.2.xfrom
Closed
Deprecate ObjectManager::merge() and ObjectManager::detach()#47Majkl578 wants to merge 1 commit intodoctrine:1.2.xfrom
Majkl578 wants to merge 1 commit intodoctrine:1.2.xfrom
Conversation
SenseException
requested changes
Apr 10, 2019
88a8a5a to
3a4a27f
Compare
alcaeus
previously approved these changes
Apr 15, 2019
greg0ire
reviewed
Apr 15, 2019
3a4a27f to
7d90900
Compare
Member
|
Before merging this, should we add |
Contributor
Author
|
We use single UPGRADE.md document in other repos, I'd stick with that. |
Member
Not everywhere, in ODM we have an UPDATE file per version: https://github.com/doctrine/mongodb-odm/tree/1.3.x |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added deprecation for
ObjectManager::merge()andObjectManager::detach()ahead of their removal in 2.0 and ORM 3.0.More context in:
EntityManager#merge()andEntityManager#detach()removal orm#1577