Skip to content

Deprecate ObjectManager::merge() and ObjectManager::detach()#47

Closed
Majkl578 wants to merge 1 commit intodoctrine:1.2.xfrom
Majkl578:deprecate-merge-detach
Closed

Deprecate ObjectManager::merge() and ObjectManager::detach()#47
Majkl578 wants to merge 1 commit intodoctrine:1.2.xfrom
Majkl578:deprecate-merge-detach

Conversation

@Majkl578
Copy link
Contributor

@Majkl578 Majkl578 added this to the 1.2.0 milestone Apr 10, 2019
@Majkl578 Majkl578 requested review from Ocramius and alcaeus April 10, 2019 13:23
@Majkl578 Majkl578 force-pushed the deprecate-merge-detach branch from 88a8a5a to 3a4a27f Compare April 10, 2019 22:36
@Majkl578 Majkl578 requested a review from SenseException April 10, 2019 22:37
SenseException
SenseException previously approved these changes Apr 15, 2019
Copy link
Member

@SenseException SenseException left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

alcaeus
alcaeus previously approved these changes Apr 15, 2019
@Majkl578 Majkl578 dismissed stale reviews from alcaeus and SenseException via 7d90900 April 16, 2019 00:07
@Majkl578 Majkl578 force-pushed the deprecate-merge-detach branch from 3a4a27f to 7d90900 Compare April 16, 2019 00:07
@alcaeus
Copy link
Member

alcaeus commented Apr 16, 2019

Before merging this, should we add UPGRADE files to document all deprecations/removals? Symfony does it this way (see relevant files for Symfony 4.3 and Symfony 5.0) and it gives users a quick way of seeing what might be broken even before installing a new version. Asking because this is a manual process that maintainers need to keep in mind when reviewing pull requests.

@Majkl578
Copy link
Contributor Author

We use single UPGRADE.md document in other repos, I'd stick with that.

@malarzm
Copy link
Member

malarzm commented Apr 16, 2019

We use single UPGRADE.md document in other repos, I'd stick with that.

Not everywhere, in ODM we have an UPDATE file per version: https://github.com/doctrine/mongodb-odm/tree/1.3.x

@Majkl578 Majkl578 closed this Apr 16, 2019
@Majkl578 Majkl578 deleted the deprecate-merge-detach branch April 16, 2019 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants