Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove TODO #8078

Merged
merged 1 commit into from
Mar 30, 2020
Merged

Remove TODO #8078

merged 1 commit into from
Mar 30, 2020

Conversation

VincentLanglet
Copy link
Contributor

This todo is here for 10 years.

Plus, I don't think these two functions should be removed or renamed.

@VincentLanglet VincentLanglet mentioned this pull request Mar 23, 2020
Closed
greg0ire
greg0ire approved these changes Mar 24, 2020
View reviewed changes
Copy link
Member

@greg0ire greg0ire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't find the reason for this and didn't do it in 10 years… fair enough.

@VincentLanglet
Copy link
Contributor Author

@greg0ire ; Do you think it can be merged ? :)

@greg0ire
Copy link
Member

I do, I approved :trollface: I just try not to merge things in the ORM without at least 2 approvals

@greg0ire greg0ire requested a review from SenseException March 30, 2020 05:55
SenseException
SenseException approved these changes Mar 30, 2020
View reviewed changes
Copy link
Member

@SenseException SenseException left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't find any plans about what the todo was referring to. Despite its removal from the docblock, a renaming or removal of these methods can still be done even without those hints.

@greg0ire greg0ire merged commit a418cf6 into doctrine:2.7 Mar 30, 2020
@greg0ire
Copy link
Member

Thanks @VincentLanglet !

@VincentLanglet VincentLanglet deleted the patch-2 branch March 30, 2020 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SenseException SenseException SenseException approved these changes

@greg0ire greg0ire greg0ire approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@VincentLanglet @greg0ire @SenseException