New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Does getDQLPart/getDQLParts will be deprecated/removed ? #8077

Closed

VincentLanglet opened this issue Mar 23, 2020 · 2 comments

Contributor

VincentLanglet commented Mar 23, 2020 •

edited

Loading

Support Question

I saw here
https://github.com/doctrine/orm/blob/master/lib/Doctrine/ORM/QueryBuilder.php#L1331
https://github.com/doctrine/orm/blob/master/lib/Doctrine/ORM/QueryBuilder.php#L1343
the following comment @todo Rename ... (or remove)

Personally I used them in some specific situation, for example if I want to add a more specific orderBy.

getQDLPart('orderBy')
resetDQLPart('order')
add my OrderBy
re-add the previous OrderBy

Is there a reason to want to withdraw theses methods ?
If not, can I remove the (or remove) comment ?

The text was updated successfully, but these errors were encountered:

Member

greg0ire commented Mar 23, 2020 •

edited

Loading

For future reference, these comments were introduced in 8d52967 10 years ago

Contributor Author

VincentLanglet commented Mar 23, 2020

Whoah, didn't see this !

I propose to remove the todo: #8078

VincentLanglet closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment