Moved logic for scheduling orphanRemoval #1281
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 on this. |
| if ($topOrExistingDocument || CollectionHelper::usesSet($assoc['strategy'])) { | ||
| $this->scheduleCollectionUpdate($value); | ||
| } | ||
| $topmostOwner = $this->getOwningDocument($value->getOwner()); | ||
| $this->visitedCollections[spl_object_hash($topmostOwner)][] = $value; | ||
| if ( ! empty($assoc['orphanRemoval']) || isset($assoc['embedded'])) { | ||
| $value->initialize(); |
There was a problem hiding this comment.
Since both remove and set (which are the only methods that can remove elements) initialize the collection before making changes I'd argue that we could actually just skip uninitialized collections here. That could save a few seconds when having a large uninitialized collection sitting around.
There was a problem hiding this comment.
set doesn't really initialize collection when used: https://github.com/doctrine/mongodb-odm/pull/1281/files#diff-23b2d33965df3f6d7b558d98a301a34aL538
There was a problem hiding this comment.
For the record discussed behaviour was changed for a moment (malarzm#6) but as agreed on IRC it's not going to make it into ODM
malarzm
force-pushed
the
poor-orphans
branch
from
b817f76 to
a2f78b7
Compare
malarzm
force-pushed
the
poor-orphans
branch
from
a2f78b7 to
8e3f4ce
Compare
malarzm
added a commit
that referenced
this pull request
Dec 14, 2015
Moved logic for scheduling orphanRemoval
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #1278 and personally I like this one better. Also I was thinking if it's worth removing embedded documents out of orphan removal's interest but probably that would mean duplicating logic for cascading.