-
-
Notifications
You must be signed in to change notification settings - Fork 510
Check for duplicates before scheduling orphanRemoval #1278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…into VoycerAG-sorting_bug
I took another look at the whole embedding issue and it is the same problem as with referenced documents: orphanRemoval (which is implied for embedded collections). For referenced documents, the sorting bug (when switching two elements) manifests itself by removing the referenced document but leaving the reference in the collection (thus leading to a proxy initialization failed error). Since both problems boil down to orphanRemoval, this PR effectively fixes that weird behavior as well. |
How about we stop using |
Superseded by #1281 |
Fixes #1275 and closes #1277 BUT increases complexity of
set
andremoveElement
whenorphanRemoval
is enabled