Skip to content

Don't unschedule orphanRemoval for null #1256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 28, 2015
Merged

Don't unschedule orphanRemoval for null #1256

merged 1 commit into from
Oct 28, 2015

Conversation

alcaeus
Copy link
Member

@alcaeus alcaeus commented Oct 28, 2015

Fixes #1255.

This fixes an issue where adding null to a PersistentCollection (or overwriting an element with null) would try to unschedule orphanRemoval for that object.

@alcaeus alcaeus added the Bug label Oct 28, 2015
@malarzm malarzm added this to the 1.0.3 milestone Oct 28, 2015
malarzm added a commit that referenced this pull request Oct 28, 2015
@malarzm malarzm merged commit 79db9b2 into doctrine:master Oct 28, 2015
@malarzm
Copy link
Member

malarzm commented Oct 28, 2015

ping @gabma

@gabma
Copy link

gabma commented Oct 28, 2015

@malarzm @alcaeus Nice! That fixed it. 👍
Thanks for your prompt replies guys!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue with commit 02f77ce
3 participants