Unschedule orphan removal if an element is re-added #1248
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alcaeus
changed the title
| @@ -551,6 +551,11 @@ public function add($value) | |||
| } | |||
| $this->coll->add($value); | |||
| $this->changed(); | |||
|
|
|||
| if ($this->uow !== null && $this->isOrphanRemovalEnabled()) { | |||
There was a problem hiding this comment.
Should same thing be done for set()?
There was a problem hiding this comment.
Yes. There was a bug that elements were not removed when being overwritten by set() - this is done properly now.
alcaeus
added a commit
that referenced
this pull request
Oct 19, 2015
Unschedule orphan removal if an element is re-added to a PersistentCollection
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a minor issue where removing an element from a PersistentCollection with orphanRemoval enabled and then re-adding it to the same collection leaves it scheduled for removal. This can produce invalid references.
This PR also fixes an issue where using
set()in a PersistentCollection with orphanRemoval enabled would not remove an element that was overwritten and is no longer part of the collection.