Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve phpdoc types #389

Merged
merged 1 commit into from
Apr 21, 2022
Merged

Improve phpdoc types #389

merged 1 commit into from
Apr 21, 2022

Conversation

BafS
Copy link
Contributor

@BafS BafS commented Apr 21, 2022

  • Removed some unhelpful comment (constructors)
  • Added some more specific types in the phpdoc

@greg0ire greg0ire added this to the 1.5.4 milestone Apr 21, 2022
@greg0ire greg0ire merged commit 25bd636 into doctrine:1.5.x Apr 21, 2022
@greg0ire
Copy link
Member

Thanks @BafS !

@ghost ghost mentioned this pull request Jan 3, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greg0ire greg0ire greg0ire approved these changes

@SenseException SenseException SenseException approved these changes

@derrabus derrabus Awaiting requested review from derrabus

Assignees
No one assigned
Labels
Static Analysis
Projects
None yet
Milestone
1.5.4
Development

Successfully merging this pull request may close these issues.
3 participants
@BafS @greg0ire @SenseException