Improve phpdoc types

lib/Doctrine/Common/DataFixtures/Event/Listener/MongoDBReferenceListener.php

@@ -17,9 +17,6 @@ final class MongoDBReferenceListener implements EventSubscriber
     /** @var ReferenceRepository */
     private $referenceRepository;
 
-    /**
-     * Initialize listener
-     */
     public function __construct(ReferenceRepository $referenceRepository)
     {
         $this->referenceRepository = $referenceRepository;
@@ -35,6 +32,8 @@ public function getSubscribedEvents()
 
     /**
      * Populates identities for stored references
+     *
+     * @return void
      */
     public function postPersist(LifecycleEventArgs $args)
     {

lib/Doctrine/Common/DataFixtures/Event/Listener/ORMReferenceListener.php

@@ -17,9 +17,6 @@ final class ORMReferenceListener implements EventSubscriber
     /** @var ReferenceRepository */
     private $referenceRepository;
 
-    /**
-     * Initialize listener
-     */
     public function __construct(ReferenceRepository $referenceRepository)
     {
         $this->referenceRepository = $referenceRepository;
@@ -36,6 +33,8 @@ public function getSubscribedEvents()
 
     /**
      * Populates identities for stored references
+     *
+     * @return void
      */
     public function postPersist(LifecycleEventArgs $args)
     {

lib/Doctrine/Common/DataFixtures/Executor/AbstractExecutor.php

@@ -62,6 +62,8 @@ public function setReferenceRepository(ReferenceRepository $referenceRepository)
 
     /**
      * Sets the Purger instance to use for this executor instance.
+     *
+     * @return void
      */
     public function setPurger(PurgerInterface $purger)
     {
@@ -80,6 +82,8 @@ public function getPurger()
      * Set the logger callable to execute with the log() method.
      *
      * @param callable $logger
+     *
+     * @return void
      */
     public function setLogger($logger)
     {
@@ -90,6 +94,8 @@ public function setLogger($logger)
      * Logs a message using the logger.
      *
      * @param string $message
+     *
+     * @return void
      */
     public function log($message)
     {
@@ -99,6 +105,8 @@ public function log($message)
 
     /**
      * Load a fixture with the given persistence manager.
+     *
+     * @return void
      */
     public function load(ObjectManager $manager, FixtureInterface $fixture)
     {
@@ -123,6 +131,8 @@ public function load(ObjectManager $manager, FixtureInterface $fixture)
     /**
      * Purges the database before loading.
      *
+     * @return void
+     *
      * @throws Exception if the purger is not defined.
      */
     public function purge()
@@ -144,8 +154,10 @@ public function purge()
     /**
      * Executes the given array of data fixtures.
      *
-     * @param array $fixtures Array of fixtures to execute.
-     * @param bool  $append   Whether to append the data fixtures or purge the database before loading.
+     * @param FixtureInterface[] $fixtures Array of fixtures to execute.
+     * @param bool               $append   Whether to append the data fixtures or purge the database before loading.
+     *
+     * @return void
      */
     abstract public function execute(array $fixtures, $append = false);
 }

lib/Doctrine/Common/DataFixtures/Loader.php

@@ -181,7 +181,7 @@ public function addFixture(FixtureInterface $fixture)
     /**
      * Returns the array of data fixtures to execute.
      *
-     * @return array $fixtures
+     * @return FixtureInterface[]
      */
     public function getFixtures()
     {

lib/Doctrine/Common/DataFixtures/ProxyReferenceRepository.php

@@ -62,6 +62,8 @@ public function serialize()
      * Unserialize reference repository
      *
      * @param string $serializedData Serialized data
+     *
+     * @return void
      */
     public function unserialize($serializedData)
     {
@@ -115,6 +117,8 @@ public function load($baseCacheName)
      * Save data fixture reference repository
      *
      * @param string $baseCacheName Base cache name
+     *
+     * @return void
      */
     public function save($baseCacheName)
     {

lib/Doctrine/Common/DataFixtures/Purger/MongoDBPurger.php

@@ -18,6 +18,8 @@ class MongoDBPurger implements PurgerInterface
      * Construct new purger instance.
      *
      * @param DocumentManager $dm DocumentManager instance used for persistence.
+     *
+     * @return void
      */
     public function __construct(?DocumentManager $dm = null)
     {
@@ -26,6 +28,8 @@ public function __construct(?DocumentManager $dm = null)
 
     /**
      * Set the DocumentManager instance this purger instance should use.
+     *
+     * @return void
      */
     public function setDocumentManager(DocumentManager $dm)
     {

lib/Doctrine/Common/DataFixtures/Purger/ORMPurger.php

@@ -225,9 +225,9 @@ private function getCommitOrder(EntityManagerInterface $em, array $classes)
     }
 
     /**
-     * @param array $classes
+     * @param ClassMetadata[] $classes
      *
-     * @return array
+     * @return string[]
      */
     private function getAssociationTables(array $classes, AbstractPlatform $platform)
     {

lib/Doctrine/Common/DataFixtures/ReferenceRepository.php

@@ -26,7 +26,7 @@ class ReferenceRepository
      * List of named references to the fixture objects
      * gathered during loads of fixtures
      *
-     * @var array
+     * @psalm-var array<string, object>
      */
     private $references = [];
 
@@ -35,7 +35,7 @@ class ReferenceRepository
      * in case if reference gets unmanaged, it will
      * use a proxy referenced by this identity
      *
-     * @var array
+     * @psalm-var array<string, mixed>
      */
     private $identities = [];
 
@@ -89,6 +89,8 @@ protected function getIdentifier($reference, $uow)
      *
      * @param string $name
      * @param object $reference
+     *
+     * @return void
      */
     public function setReference($name, $reference)
     {
@@ -108,6 +110,8 @@ public function setReference($name, $reference)
      *
      * @param string $name
      * @param mixed  $identity
+     *
+     * @return void
      */
     public function setReferenceIdentity($name, $identity)
     {
@@ -213,7 +217,7 @@ public function hasIdentity($name)
     /**
      * Get all stored identities
      *
-     * @return array
+     * @psalm-return array<string, object>
      */
     public function getIdentities()
     {
@@ -223,7 +227,7 @@ public function getIdentities()
     /**
      * Get all stored references
      *
-     * @return array
+     * @psalm-return array<string, object>
      */
     public function getReferences()
     {

lib/Doctrine/Common/DataFixtures/Sorter/TopologicalSorter.php

@@ -34,7 +34,7 @@ class TopologicalSorter
     /**
      * Volatile variable holding calculated nodes during sorting process.
      *
-     * @var array
+     * @var ClassMetadata[]
      */
     private $sortedNodeList = [];
 
@@ -46,8 +46,6 @@ class TopologicalSorter
     private $allowCyclicDependencies;
 
     /**
-     * Construct TopologicalSorter object
-     *
      * @param bool $allowCyclicDependencies
      */
     public function __construct($allowCyclicDependencies = true)
@@ -100,7 +98,7 @@ public function addDependency($fromHash, $toHash)
      *
      * Note: Highly performance-sensitive method.
      *
-     * @return array
+     * @return ClassMetadata[]
      *
      * @throws RuntimeException
      * @throws CircularReferenceException
@@ -128,6 +126,8 @@ public function sort()
      *
      * Note: Highly performance-sensitive method.
      *
+     * @return void
+     *
      * @throws RuntimeException
      * @throws CircularReferenceException
      */

tests/Doctrine/Tests/Common/DataFixtures/Purger/ORMPurgerExcludeTest.php

@@ -72,7 +72,7 @@ protected function loadTestData()
      * Execute test purge
      *
      * @param string|null $expression
-     * @param array       $list
+     * @param string[]    $list
      */
     public function executeTestPurge($expression, array $list, ?callable $filter = null): void
     {