Leverage PSR-4 to provide a shallower tree#138
Conversation
| beStrictAboutOutputDuringTests="true" | ||
| beStrictAboutTestsThatDoNotTestAnything="true" | ||
| beStrictAboutTodoAnnotatedTests="true" | ||
| bootstrap="vendor/autoload.php" |
There was a problem hiding this comment.
I'm sure this is need it but I'm not sure why. Or rather, I'm not sure why it worked before. It's as if phpunit assumed psr 0
There was a problem hiding this comment.
Not needed when PHPUnit is executed from local composer installation (as project dependency)
This should make fuzzy matchers more efficient.
greg0ire
force-pushed
the
shallow_tree
branch
from
118a6f1 to
9304736
Compare
|
If you are ok with this I might do the same on other Doctrine libs. |
lcobucci
left a comment
lcobucci
left a comment
There was a problem hiding this comment.
Thanks for your effort but the Doctrine team voted against PSR-4 and also decided to not apply the "shallower tree" in any of our projects.
| beStrictAboutOutputDuringTests="true" | ||
| beStrictAboutTestsThatDoNotTestAnything="true" | ||
| beStrictAboutTodoAnnotatedTests="true" | ||
| bootstrap="vendor/autoload.php" |
There was a problem hiding this comment.
Not needed when PHPUnit is executed from local composer installation (as project dependency)
|
Same here: shallow tree is not an advantage to me, and the doctrine
organisation voted against PSR-4 specifically due to the introduced tooling
complexity added by path prefixing.
I'd personally still very much like to keep the path 1:1 with the class
names, as it should be.
PSR-4 as an autoloader is fine and already implemented in this package.
On 22 Jan 2018 00:05, "Luís Cobucci" <notifications@github.com> wrote:
*@lcobucci* requested changes on this pull request.
Thanks for your effort but the Doctrine team voted against PSR-4 and also
decided to not apply the "shallower tree" in any of our projects.
------------------------------
In phpunit.xml.dist
<#138 (comment)>:
@@ -8,16 +8,17 @@
beStrictAboutOutputDuringTests="true"
beStrictAboutTestsThatDoNotTestAnything="true"
beStrictAboutTodoAnnotatedTests="true"
+ bootstrap="vendor/autoload.php"
Not needed when PHPUnit is executed from local composer installation
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#138 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAJakBJSrw3DUTEaAE2nPfcCvzQmRkhrks5tM8K_gaJpZM4Rl71C>
.
|
|
Closing then |
|
2021 to rethink this? |
|
I didn't follow how things evolved, but I noticed that the DBAL does use a shallow tree since 3.0.x so maybe this might be reconsidered indeed. |
4 participants
This should make fuzzy matchers more efficient.