Merged
Conversation
Member
|
LGTM 👍 |
Contributor
Author
|
Thank you merging |
Member
|
I think this should have been done on 1.5, and the depth of the tree shouldn't have been preserved. See #138 |
Member
|
Depth of tree is correctly preserved, as the doctrine organisation does not
endorse PSR-4 namespace prefixes and still suggests for the sake of tooling
simplicity to use PSR-0 path mappings.
…On 21 Jan 2018 20:35, "Grégoire Paris" ***@***.***> wrote:
I think this should have been done on 1.5, and the depth of the tree
shouldn't have been preserved. See https://github.com/doctrine/
collections/pull/138/files
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#127 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAJakLlcmnedJ7M-5X7LdtnPw70Ho57Rks5tM5GGgaJpZM4Og13I>
.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sorry for bothering this super stable package. May I ask to consider to update to PSR-4?
Im using https://github.com/humbug/php-scoper which automatically rewrites the namespace before Im building a PHAR.