Ignore additional generics annotations#367
Closed
sanmai wants to merge 1 commit intodoctrine:1.10.xfrom
Closed
Conversation
Including for Phan, Psalm, and Infection.
greg0ire
reviewed
Sep 29, 2020
| // Phan, Psalm, Infection | ||
| 'phan' => true, | ||
| 'psalm' => true, | ||
| 'infection' => true, |
Member
There was a problem hiding this comment.
Sorry, what are we ignoring exactly here? Do this ignore rule ignore annotations prefixed with psalm? I'm asking because I'm familiar with @psalm-*, but not with @psalm if that's a thing.
Contributor
Author
There was a problem hiding this comment.
No, it is exactly about @psalm-* thing. But looking at #298 it might be not required any more.
Can you confirm that dashed annotations like @psalm-return are automatically ignored?
Member
There was a problem hiding this comment.
yes, dashed annotations are automatically ignored, as they cannot be valid doctrine annotations anyway (as dashes are forbidden in class names)
Contributor
Author
There was a problem hiding this comment.
Thank you for the confirmation. Then this PR is indeed unnecessary.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Including for Phan, Psalm, and Infection.