Skip to content

Comments

Ignore PHPStan generics annotations#298

Merged
alcaeus merged 3 commits intodoctrine:1.9from
marcortola:feature/ignore-phpstan-generics
Jan 16, 2020
Merged

Ignore PHPStan generics annotations#298
alcaeus merged 3 commits intodoctrine:1.9from
marcortola:feature/ignore-phpstan-generics

Conversation

@marcortola
Copy link
Contributor

Copy link
Member

@alcaeus alcaeus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I'd like to let @ondrejmirtes confirm that the list is complete and we're not forgetting anything before merging this.

@ondrejmirtes
Copy link
Contributor

Do annotations with - need to be ignored or not? Like @phpstan-param or @template-covariant...

@ondrejmirtes
Copy link
Contributor

There's also @use - reserved for generic traits. (They're not supported yet.)

@stof
Copy link
Member

stof commented Dec 19, 2019

Do annotations with - need to be ignored or not? Like @phpstan-param or @template-covariant...

@ondrejmirtes no. They are already ignored automatically, because - is not valid in a class name anyway.

@alcaeus
Copy link
Member

alcaeus commented Dec 19, 2019

Do annotations with - need to be ignored or not?

This issue was fixed when psalm introduced @psalm-template.

There's also @use - reserved for generic traits. (They're not supported yet.)

Good point. @Mortola can you please add use to the list? Thanks!

@alcaeus alcaeus dismissed Ocramius’s stale review January 16, 2020 12:35

BC impact marginal

@alcaeus alcaeus self-assigned this Jan 16, 2020
@alcaeus alcaeus added this to the v1.9.0 milestone Jan 16, 2020
@alcaeus alcaeus merged commit 01ed789 into doctrine:1.9 Jan 16, 2020
@alcaeus
Copy link
Member

alcaeus commented Jan 16, 2020

Thanks @marcortola!

@localheinz
Copy link
Contributor

Any chance this can get a release soon?

@alcaeus
Copy link
Member

alcaeus commented Apr 1, 2020

@localheinz my apologies, I got side-tracked and completely forgot about this. I made some changes to the branch structure, but want to revisit #271 in time for 1.9. Please shout at me if we don't have a release within a week 😉

@marcortola marcortola deleted the feature/ignore-phpstan-generics branch April 1, 2020 12:03
@alcaeus alcaeus modified the milestones: 1.9.0, 1.10.0 Apr 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants