Skip to content

fix: Add fail_level to reviewdog actions #1640

@michelabboud

Description

@michelabboud

Description

The CI review workflow (review.yml) produces deprecation warnings on every PR:

Input 'fail_on_error' has been deprecated with message: Deprecated, use fail_level instead.

These are emitted by the 5 reviewdog actions that have migrated to fail_level (misspell, hadolint, yamllint, actionlint, shellcheck). The fail_on_error input was never set explicitly in the workflow — the warnings come from the actions' internal action.yml resolving the deprecated input to its default value.

Additionally, none of the reviewdog steps have failure thresholds configured, so linting errors don't actually fail the CI job.

Fix

  • Add fail_level: error to the 5 actions that support it
  • Use fail_on_error: "true" for action-shfmt (which hasn't added fail_level yet)

Reference

PR

#1638

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions