-
Notifications
You must be signed in to change notification settings - Fork 4k
Open
Description
Description
The CI review workflow (review.yml) produces deprecation warnings on every PR:
Input 'fail_on_error' has been deprecated with message: Deprecated, use fail_level instead.
These are emitted by the 5 reviewdog actions that have migrated to fail_level (misspell, hadolint, yamllint, actionlint, shellcheck). The fail_on_error input was never set explicitly in the workflow — the warnings come from the actions' internal action.yml resolving the deprecated input to its default value.
Additionally, none of the reviewdog steps have failure thresholds configured, so linting errors don't actually fail the CI job.
Fix
- Add
fail_level: errorto the 5 actions that support it - Use
fail_on_error: "true"foraction-shfmt(which hasn't addedfail_levelyet)
Reference
PR
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels