Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Angular 16 #1993

Merged
merged 20 commits into from
Jul 18, 2024
Merged
Prev Previous commit
Next Next commit
Some random fixes in attempt to fix CircleCI failure
1. Noticed mocks have extra fields, unlikely to make a difference
2. Try scrollTo, looks like it may be partially cut off in video
3. Use data-cy with new id as selector; lame theory that the
register workflow dialog had been invoked, and it has the same
id
  • Loading branch information
Charles Overbeck committed Jul 16, 2024
commit 053a54c3b4c8b97a6d7400e556b6274b5e9f6519
60 changes: 30 additions & 30 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -320,26 +320,26 @@ workflows:
context:
- dockerhub
- sonarcloud
- integration_test:
name: integration_test_1
integration_test_name: group1
filters:
tags:
only: /.*/
requires:
- lint_license_unit_test_coverage
context:
- dockerhub
- integration_test:
name: integration_test_2
integration_test_name: group2
filters:
tags:
only: /.*/
requires:
- lint_license_unit_test_coverage
context:
- dockerhub
# - integration_test:
# name: integration_test_1
# integration_test_name: group1
# filters:
# tags:
# only: /.*/
# requires:
# - lint_license_unit_test_coverage
# context:
# - dockerhub
# - integration_test:
# name: integration_test_2
# integration_test_name: group2
# filters:
# tags:
# only: /.*/
# requires:
# - lint_license_unit_test_coverage
# context:
# - dockerhub
- integration_test:
name: integration_test_3
integration_test_name: group3
Expand All @@ -350,16 +350,16 @@ workflows:
- lint_license_unit_test_coverage
context:
- dockerhub
- integration_test:
name: integration_test_4
integration_test_name: immutableDatabaseTests
filters:
tags:
only: /.*/
requires:
- lint_license_unit_test_coverage
context:
- dockerhub
# - integration_test:
# name: integration_test_4
# integration_test_name: immutableDatabaseTests
# filters:
# tags:
# only: /.*/
# requires:
# - lint_license_unit_test_coverage
# context:
# - dockerhub
- local_smoke_tests:
filters:
tags:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,7 @@ <h4>Register Tool</h4>
required
matTooltip="Git Repository path"
placeholder="e.g. CancerCollaboratory/dockstore-tool-liftover"
data-cy="toolSourceRepoInput"
/>
<mat-error *ngIf="formErrors.gitPath">{{ formErrors.gitPath }}</mat-error>
</mat-form-field>
Expand Down